Split mapping.csv into pages to bypass 10 MB workspace upload limit#4856
Open
pritishpai wants to merge 3 commits into
Open
Split mapping.csv into pages to bypass 10 MB workspace upload limit#4856pritishpai wants to merge 3 commits into
pritishpai wants to merge 3 commits into
Conversation
…ce upload limit Co-authored-by: Isaac
…load limit Co-authored-by: Isaac
… until NotFound Co-authored-by: Isaac
pritishpai
force-pushed
the
fix/mapping-file-size-limit
branch
from
e5c4317 to
edd3071
Compare
pritishpai
had a problem deploying
to
account-admin
GitHub Actions
Failure
|
❌ 41/44 passed, 2 flaky, 3 failed, 5 skipped, 7h15m55s total ❌ test_hiveserde_table_ctas_migration_job: TimeoutError: Timed out after 0:05:00 (6m39.084s)❌ test_table_migration_job_refreshes_migration_status[regular-migrate-tables]: AssertionError: Workflow failed: migrate-tables (31m0.509s)❌ test_table_migration_job_refreshes_migration_status[hiveserde-migrate-external-hiveserde-tables-in-place-experimental]: AssertionError: Workflow failed: migrate-external-hiveserde-tables-in-place-experimental (30m55.07s)Flaky tests:
Running from acceptance #9022 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4675
Customers with ~100K+ tables in an external HMS hit a
BadRequest: File size imported is (16413218 bytes), exceeded max size (10485760 bytes)error when runningcreate-table-mapping.mapping.csvgrows to ~16 MB, exceeding this regardless ofquery_statement_disposition.save()now chunks rules into pages of 50,000 rows each (~8 MB/file), writingmapping.csvfor the first page andmapping-1.csv,mapping-2.csv, … for overflow.load()readsmapping.csvthen followsmapping-1.csv,mapping-2.csv, … untilNotFound, assembling the full rule list transparently to all callers.mapping.csvinstallations load unchanged.Test plan
save()with > 50,000 rules writes bothmapping.csvandmapping-1.csvwith correct row countsload()with multiple pages assembles all rules in orderload()with a single-page legacymapping.csvstill returns all rules (backward compat)BadRequestoncreate-table-mapping