Skip to content

India_NationalAccountsStatistics configs#1863

Open
saanikaaa wants to merge 3 commits intodatacommonsorg:masterfrom
saanikaaa:mospi_economy
Open

India_NationalAccountsStatistics configs#1863
saanikaaa wants to merge 3 commits intodatacommonsorg:masterfrom
saanikaaa:mospi_economy

Conversation

@saanikaaa
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @saanikaaa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the dataset for India's economic statistics by adding comprehensive configuration files for National Accounts data from MOSPI. It enables the ingestion of detailed information on GDP, GSDP, and GVA, broken down by various estimates, price types, and economic sectors, as well as by state for GSDP. This enhancement will provide a richer foundation for economic analysis and data visualization related to India.

Highlights

  • New Data Configurations: Introduced new configuration files for India's National Accounts Statistics, covering various economic indicators.
  • GDP Data: Added configurations for Annual GDP and First Advance GDP estimates, including both nominal and real values.
  • GSDP Data: Included configurations for Gross State Domestic Product (GSDP) at both constant and current prices, with data for various Indian states and Union Territories.
  • GVA Data: Provided configurations for Gross Value Added (GVA) across multiple revision stages (First Advance, Provisional, Second Advance, Second Revised, Third Revised) and economic sectors.
  • Test Data and Mappings: Accompanying test input and output CSV files, along with TMCF (Template CSV Mapping File) files, have been added to validate the data import process for GDP and GSDP.
Changelog
  • statvar_imports/india_mospi/india_national_accounts_statistics/GDP_Annual_metadata.csv
    • Added metadata for annual Gross Domestic Product (GDP) data.
  • statvar_imports/india_mospi/india_national_accounts_statistics/GDP_Annual_pvmap.csv
    • Added property-value mappings for annual GDP, including nominal and real values, and historical year data.
  • statvar_imports/india_mospi/india_national_accounts_statistics/GDP_India_FirstAdvanced_metadata.csv
    • Added metadata for India's First Advance GDP estimates.
  • statvar_imports/india_mospi/india_national_accounts_statistics/GDP_India_FirstAdvanced_pvmap.csv
    • Added property-value mappings for First Advance GDP estimates, covering nominal and real values, and future year projections.
  • statvar_imports/india_mospi/india_national_accounts_statistics/GSDP_Constant_metadata.csv
    • Added metadata for Gross State Domestic Product (GSDP) at constant prices.
  • statvar_imports/india_mospi/india_national_accounts_statistics/GSDP_Constant_pvmap.csv
    • Added property-value mappings for GSDP at constant prices, including growth rates and data for various Indian states/UTs.
  • statvar_imports/india_mospi/india_national_accounts_statistics/GSDP_Current_metadata.csv
    • Added metadata for Gross State Domestic Product (GSDP) at current prices.
  • statvar_imports/india_mospi/india_national_accounts_statistics/GSDP_Current_pvmap.csv
    • Added property-value mappings for GSDP at current prices, including growth rates and data for various Indian states/UTs.
  • statvar_imports/india_mospi/india_national_accounts_statistics/GVA_FristAdvanceEstimates_metadata.csv
    • Added metadata for First Advance Gross Value Added (GVA) estimates.
  • statvar_imports/india_mospi/india_national_accounts_statistics/GVA_FristAdvanceEstimates_pvmap.csv
    • Added property-value mappings for First Advance GVA estimates, covering various economic sectors and historical/future years.
  • statvar_imports/india_mospi/india_national_accounts_statistics/GVA_ProvisionalEstimates_metadata.csv
    • Added metadata for Provisional Gross Value Added (GVA) estimates.
  • statvar_imports/india_mospi/india_national_accounts_statistics/GVA_ProvisionalEstimates_pvmap.csv
    • Added property-value mappings for Provisional GVA estimates, covering various economic sectors and historical/future years.
  • statvar_imports/india_mospi/india_national_accounts_statistics/GVA_SecondAdvanceEstimates_metadata.csv
    • Added metadata for Second Advance Gross Value Added (GVA) estimates.
  • statvar_imports/india_mospi/india_national_accounts_statistics/GVA_SecondAdvanceEstimates_pvmap.csv
    • Added property-value mappings for Second Advance GVA estimates, covering various economic sectors and historical/future years.
  • statvar_imports/india_mospi/india_national_accounts_statistics/GVA_SecondRevisedEstimates_metadata.csv
    • Added metadata for Second Revised Gross Value Added (GVA) estimates.
  • statvar_imports/india_mospi/india_national_accounts_statistics/GVA_SecondRevisedEstimates_pvmap.csv
    • Added property-value mappings for Second Revised GVA estimates, covering various economic sectors and historical years.
  • statvar_imports/india_mospi/india_national_accounts_statistics/GVA_ThirdRevisedEstimates_metadata.csv
    • Added metadata for Third Revised Gross Value Added (GVA) estimates.
  • statvar_imports/india_mospi/india_national_accounts_statistics/GVA_ThirdRevisedEstimates_pvmap.csv
    • Added property-value mappings for Third Revised GVA estimates, covering various economic sectors and historical/future years.
  • statvar_imports/india_mospi/india_national_accounts_statistics/test_data/GDP_ANNUAL_output.csv
    • Added test output data for annual GDP.
  • statvar_imports/india_mospi/india_national_accounts_statistics/test_data/GDP_ANNUAL_output.tmcf
    • Added TMCF (Template CSV Mapping File) for annual GDP test output.
  • statvar_imports/india_mospi/india_national_accounts_statistics/test_data/GDP_Annual_input.csv
    • Added test input data for annual GDP.
  • statvar_imports/india_mospi/india_national_accounts_statistics/test_data/GDP_India_FirstAdvanced_input.csv
    • Added test input data for First Advance GDP estimates.
  • statvar_imports/india_mospi/india_national_accounts_statistics/test_data/GDP_India_FirstAdvanced_output.csv
    • Added test output data for First Advance GDP estimates.
  • statvar_imports/india_mospi/india_national_accounts_statistics/test_data/GDP_India_FirstAdvanced_output.tmcf
    • Added TMCF for First Advance GDP test output.
  • statvar_imports/india_mospi/india_national_accounts_statistics/test_data/GSDP_Constant_input.csv
    • Added test input data for GSDP at constant prices.
  • statvar_imports/india_mospi/india_national_accounts_statistics/test_data/GSDP_Constant_output.tmcf
    • Added TMCF for GSDP at constant prices test output.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR adds configuration files for importing India's National Accounts Statistics. The changes look mostly good, but there are a few issues to address. There's a typo in the filenames for GVA_FristAdvanceEstimates (Frist should be First). More importantly, there are several data correctness issues in the pvmap files, including incorrect Wikidata IDs for some places, a copy-paste error in a key, and an invalid value """"" used in multiple GVA pvmap files which will likely cause processing errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant