Skip to content

NASA_VIIRSActiveFiresEvents_Fixes_corrected config path as well as added skip_validation_config #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
balit-raibot wants to merge 3 commits into
base: master
Choose a base branch
from
+8 −3
Open

NASA_VIIRSActiveFiresEvents_Fixes_corrected config path as well as added skip_validation_config #2013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5956bcf
corrected config path as well as added skip_validation_config
balit-raibot May 15, 2026
f45c66e
fixed config
balit-raibot May 15, 2026
1357e35
added invoke_import_tool false
balit-raibot May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/fires/firms/fire_events_pipeline_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
# Output events csv into a common folder with a year in filename,
# as the import automation can copy all files in a single folder.
"output_dir":
"gs://{gcs_bucket}/{gcs_folder}/{stage}/{import_name}-{stage}-{year}-without-usa-",
"gs://{gcs_bucket}/{gcs_folder}/{import_name}-{stage}-{year}-without-usa-",
Comment thread
balit-raibot marked this conversation as resolved.
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The PR description mentions a goal to "avoid 'events/events' folder and have just 'events' folder". However, the current change removes the {stage}/ directory (which resolves to events/) from the path entirely, while keeping the {stage} suffix in the filename prefix. This results in the output being placed in the parent directory (scripts/fires/firms/) with no events/ subfolder.

If the intention was to have a single events/ folder and remove the redundancy from the filename, consider keeping {stage}/ in the path but removing {stage}- from the filename prefix.

Suggested change
"gs://{gcs_bucket}/{gcs_folder}/{import_name}-{stage}-{year}-without-usa-",
"gs://{gcs_bucket}/{gcs_folder}/{stage}/{import_name}-{year}-without-usa-",

"event_type":
"FireEvent",

Expand Down
9 changes: 7 additions & 2 deletions scripts/fires/firms/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,13 @@
"cleaned_csv": ""
}
],
"user_script_timeout": 86400,
"cron_schedule": "0 5 1 * *"
"cron_schedule": "0 5 1 * *",
"config_override": {
"skip_gcs_upload": true,
"invoke_differ_tool": false,
"invoke_import_validation": false,
"invoke_import_tool": false
}
Comment thread
balit-raibot marked this conversation as resolved.
Comment on lines +19 to +25
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The changes in the manifest appear to disable the automated import and remove safety timeouts:

  1. Timeout Removal: user_script_timeout was removed. Given that this pipeline processes global fire events for a full year, it likely requires a significant amount of time. Removing this may cause the automation to kill the job prematurely.
  2. Import Disabled: Setting "invoke_import_tool": false and "skip_gcs_upload": true prevents the generated data from being loaded into the database. The PR description only mentions skipping validation and the differ.

If the goal is to fix the production import, these settings should likely be adjusted to only skip the intended steps.

            "user_script_timeout": 86400,
            "cron_schedule": "0 5 1 * *",
            "config_override": {
                "invoke_differ_tool": false,
                "invoke_import_validation": false
            }

}
]
}
Loading