Add initial Data Commons Platform database simple import support #469

dwnoble · 2026-01-31T00:45:19Z

Added scaffold DataCommonsPlatformDb class and stubs in simple/stats/db.py.
Add environment variable configuration and factory logic for backend selection.
Add unit tests for configuration parsing in db_test.py.

gemini-code-assist · 2026-01-31T00:45:33Z

Summary of Changes

Hello @dwnoble, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request lays the groundwork for integrating with the Data Commons Platform by adding a new database backend. It establishes the necessary class structure, introduces environment-based configuration, and updates the system's database selection mechanism to support this new platform. The changes enable future development for data import and interaction with the Data Commons Platform.

Highlights

New Database Backend: Introduced a new DataCommonsPlatformDb class to provide initial support for interacting with the Data Commons Platform, including stub methods for data insertion and selection.
Environment Variable Configuration: Added new environment variables (USE_DATACOMMONS_PLATFORM, DATACOMMONS_PLATFORM_URL) and corresponding logic to configure the Data Commons Platform backend.
Database Factory Integration: Updated the database creation factory (create_and_update_db) and configuration retrieval logic (_get_db_config) to recognize and prioritize the new Data Commons Platform backend.
Unit Tests: Included a new unit test to validate the correct parsing of Data Commons Platform configuration from environment variables.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces initial support for a new database backend, the Data Commons Platform, including a new DB type, configuration, a stub Db interface implementation, and factory logic, along with unit tests. A security review identified a potential information disclosure vulnerability where the platform URL, which may contain sensitive credentials, is logged in its entirety, potentially exposing secrets in application logs. Additionally, there are areas for improvement regarding correctness and maintainability, such as an incorrect method signature, an unnecessary method, and hardcoded strings in a test.

gemini-code-assist · 2026-01-31T00:56:35Z

simple/stats/db.py

+    logging.info("TODO: Writing %s observations to [%s]", len(observations_df),
+                 self.url)


The DataCommonsPlatformDb class logs the full URL configured via the DATACOMMONS_PLATFORM_URL environment variable. This can lead to information disclosure as URLs may contain sensitive credentials. It is recommended to sanitize the URL or log only the host portion. Additionally, please note that the signature of insert_observations (lines 386-390) is inconsistent with the base class Db and other implementations like SqlDb, expecting list[Observation] instead of pd.DataFrame. This will cause a runtime error.

logging.info("TODO: Writing %s observations to Data Commons Platform", len(observations_df))

gemini-code-assist · 2026-01-31T00:56:35Z

simple/stats/db.py

+
+  def insert_triples(self, triples: list[Triple]):
+    # TODO: Implement triple insertion into Data Commons Platform.
+    logging.info("TODO: Writing %s triples to [%s]", len(triples), self.url)


The DataCommonsPlatformDb class logs the full URL configured via the DATACOMMONS_PLATFORM_URL environment variable. URLs for platforms often contain sensitive information such as API keys, tokens, or credentials in the query parameters or as part of the path. Logging the full URL without sanitization can lead to the exposure of these secrets in the application logs.

Recommendation: Sanitize the URL before logging it, or log only the host portion of the URL.

logging.info("TODO: Writing %s triples to Data Commons Platform", len(triples))

gemini-code-assist · 2026-01-31T00:56:35Z

simple/stats/db.py

+  def commit(self):
+    # Not applicable for Data Commons Platform.
+    pass


The commit method is not part of the Db abstract base class interface. To maintain a clean and consistent API, it's better to remove methods that are not part of the public interface defined by the base class, especially if they are just no-ops.

gemini-code-assist · 2026-01-31T00:56:35Z

simple/tests/stats/db_test.py

+    self.assertEqual(get_datacommons_platform_config_from_env(), {
+        "type": "datacommons_platform",
+        "params": {
+            "datacommons_platform_url": "https://test_url"
+        }
+    })


For better maintainability and to avoid magic strings, it's recommended to use the constants defined in stats.db for the dictionary keys and values in this assertion.

You'll need to add the following imports at the top of the file:

from stats.db import ( DATACOMMONS_PLATFORM_URL, FIELD_DB_PARAMS, FIELD_DB_TYPE, TYPE_DATACOMMONS_PLATFORM, )

Suggested change

self.assertEqual(get_datacommons_platform_config_from_env(), {

"type": "datacommons_platform",

"params": {

"datacommons_platform_url": "https://test_url"

}

})

self.assertEqual(get_datacommons_platform_config_from_env(), {

FIELD_DB_TYPE: TYPE_DATACOMMONS_PLATFORM,

FIELD_DB_PARAMS: {

DATACOMMONS_PLATFORM_URL: "https://test_url"

}

})

clincoln8

🎉

clincoln8 · 2026-02-03T02:18:24Z

simple/stats/db.py

+  return {
+      FIELD_DB_TYPE: TYPE_DATACOMMONS_PLATFORM,
+      FIELD_DB_PARAMS: {
+          DATACOMMONS_PLATFORM_URL: dcp_url,


long term discussion point: we should align on how to refer "instances" of the platform and their api urls. I assume this URL would be pointing to the dcp api server; do we just want to be calling that the "dcp url" or have a more specific name so that it doesn't get confused with a future "admin website url" or potentially user facing website url?
Do we want to refer to it as a "platform url" or more of an "instance url"?
I think this matters more when we start writing external documentation and the wording used when talking to DCP owners, but it'd be nice if we align early so the code can be consistent. Noted in b/481115789

dwnoble added 3 commits January 30, 2026 16:40

Added dcp import scaffolding

e7f5530

removed extra code

c648ae6

removed extra code

d521d19

dwnoble requested a review from clincoln8 January 31, 2026 00:45

gemini-code-assist bot reviewed Jan 31, 2026

View reviewed changes

clincoln8 approved these changes Feb 3, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add initial Data Commons Platform database simple import support #469

Add initial Data Commons Platform database simple import support #469

dwnoble commented Jan 31, 2026

Uh oh!

gemini-code-assist bot commented Jan 31, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jan 31, 2026

Uh oh!

gemini-code-assist bot Jan 31, 2026

Uh oh!

gemini-code-assist bot Jan 31, 2026

Uh oh!

gemini-code-assist bot Jan 31, 2026

Uh oh!

clincoln8 left a comment

Uh oh!

clincoln8 Feb 3, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		logging.info("TODO: Writing %s observations to [%s]", len(observations_df),
		self.url)

Add initial Data Commons Platform database simple import support #469

Are you sure you want to change the base?

Add initial Data Commons Platform database simple import support #469

Conversation

dwnoble commented Jan 31, 2026

Uh oh!

gemini-code-assist bot commented Jan 31, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

clincoln8 left a comment

Choose a reason for hiding this comment

Uh oh!

clincoln8 Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

clincoln8 Feb 3, 2026 •

edited

Loading