Add ingestion workflow logic#505
Open
vish-cs wants to merge 1 commit into
Open
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements a comprehensive import automation and Spanner ingestion pipeline. Key additions include Terraform configurations for GCP infrastructure, Cloud Workflows for process orchestration, and two Python-based helper services for managing ingestion tasks and Pub/Sub events. The code review identified several high-priority concerns, including a violation of the principle of least privilege in IAM role assignments and a security vulnerability in the JWT verification logic. Additionally, the reviewer noted the use of placeholder SQL in the aggregation utility, non-idiomatic flag parsing in Cloud Functions, and recommended enabling deletion protection for the Spanner database.
Code is being migrated from the data repo to import repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code under workflow and Terraform folders is copied as-is from the data repo as part of the migration.
Changes are made to pom.xml and SpannerClient.java to read the schema file from the ingestion-helper.