Skip to content

Add NL sidebar for website autopush on dc-mixer-default to enable v2/resolve for SV search through NL server #6210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shixiao-coder wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add NL sidebar for website autopush on dc-mixer-default to enable v2/resolve for SV search through NL server #6210

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fa08228
Add NL sidebar for website autopush on dc-mixer-default to enable v2/…
shixiao-coder Apr 15, 2026
4cb1c2c
Merge branch 'master' into add-embedding-sidebar-to-mixer-in-autopush
shixiao-coder Apr 15, 2026
74149a8
Merge branch 'master' into add-embedding-sidebar-to-mixer-in-autopush
shixiao-coder Apr 20, 2026
846ed59
Merge branch 'master' into add-embedding-sidebar-to-mixer-in-autopush
shixiao-coder Apr 21, 2026
42cd81c
Merge branch 'master' into add-embedding-sidebar-to-mixer-in-autopush
shixiao-coder Apr 21, 2026
5605bc9
Merge branch 'master' into add-embedding-sidebar-to-mixer-in-autopush
shixiao-coder Apr 29, 2026
109a8d6
Merge branch 'master' into add-embedding-sidebar-to-mixer-in-autopush
shixiao-coder May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions skaffold.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ profiles:
mixer.hostProject: "datcom-website-autopush"
mixer.serviceName: "website-esp.endpoints.datcom-website-autopush.cloud.goog"
serviceGroups.recon.enableEmbeddingsSidecar: "false"
serviceGroups.default.enableEmbeddingsSidecar: "true"
Copy link
Copy Markdown
Contributor

@gmechali gmechali Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/datacommonsorg/mixer/blob/303a7931ac3e5f9436571fbd0c4b6432182b1de4/deploy/helm_charts/mixer/values.yaml#L441

In mixer, we set enableEmbeddingsSidecar to true for recon, which is why the line above sets it to false for website's recon.

Is it intentional to put this in defualt? Why have it in different mixer service groups across website and mixer?

Copy link
Copy Markdown
Contributor

@clincoln8 clincoln8 Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For website, the recon workload isn't used:

website/deploy/helm_charts/envs/autopush.yaml

Lines 95 to 96 in 3f077cb

serviceGroups:
recon: null

resolve traffic is routed to the default workload. Which is why for website-autopush we want the embeddings server in default and not recon

Copy link
Copy Markdown
Contributor

@gmechali gmechali Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xiao, separate note is that this provides an added risk at deployment. So just make sure to monitor when this gets released to autopush, staging and prod and just double check this looks healthy.
Might want a note to secondary oncaller when he does the release.

- name: mixer-autopush
customActions:
- name: deploy-cloud-esp-mixer-autopush
Expand Down
Loading