Skip to content

Automated Integration Test Goldens Update from CI #6236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
datacommons-robot-author wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Automated Integration Test Goldens Update from CI #6236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8997c5
feat: Update goldens from Cloud Build workflow (build 72b047a4-5cf7-4…
datacommons-robot-author Apr 23, 2026
661f694
Merge branch 'master' into nl-golden-update-72b047a4-5cf7-4bac-9e1a-b…
gmechali Apr 27, 2026
df42be8
Merge branch 'master' into nl-golden-update-72b047a4-5cf7-4bac-9e1a-b…
gmechali Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ar/howarefactorslikeobesity,bloodpressureandasthmaimpactedbyclimatechange/debug_info.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
0.63385,
0.63227,
0.63222,
0.6305,
0.63049,
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change in precision (from 0.6305 to 0.63049) increases review noise. Per the general rules, floating-point scores in test data should be rounded to a consistent, lower precision to make tests more robust against insignificant model output variations.

Suggested change
0.63049,
0.6305,
References
  1. Round floating-point scores in test data to a consistent, lower precision. This makes tests more robust against insignificant model output variations and reduces review noise.

0.6303,
0.62984,
0.62957
Expand Down
8 changes: 4 additions & 4 deletions ...test_data/e2e_date_range/femalepopulationincaliforniacountiesbefore2020/chart_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@
"tiles": [
{
"statVarKey": [
"Count_Death_Female_2017"
"Count_Death_Female_2002"
],
"title": "Count of Mortality Event: Female in Counties of California (${date})",
"type": "MAP"
Expand All @@ -209,7 +209,7 @@
"showHighestLowest": true
},
"statVarKey": [
"Count_Death_Female_2017"
"Count_Death_Female_2002"
],
"title": "Count of Mortality Event: Female in Counties of California (${date})",
"type": "RANKING"
Expand Down Expand Up @@ -929,8 +929,8 @@
"name": "Count of Mortality Event: Female",
"statVar": "Count_Death_Female"
},
"Count_Death_Female_2017": {
"date": "2017",
"Count_Death_Female_2002": {
"date": "2002",
"name": "Count of Mortality Event: Female",
"statVar": "Count_Death_Female"
},
Expand Down
Loading