Feat(Bio Inventory): Add Bio Inventory Layer - #182
Merged
Conversation
arnaudfnr
force-pushed
the
arnaudfnr/fix-indicators
branch
from
July 8, 2026 11:18
186c3b5 to
693d37a
Compare
arnaudfnr
force-pushed
the
arnaudfnr/feat-add_bio_inventory
branch
from
July 9, 2026 23:16
c5ce527 to
fc3279d
Compare
arnaudfnr
force-pushed
the
arnaudfnr/fix-indicators
branch
2 times, most recently
from
July 13, 2026 12:49
58a40e0 to
2dabde8
Compare
arnaudfnr
force-pushed
the
arnaudfnr/feat-add_bio_inventory
branch
2 times, most recently
from
July 13, 2026 13:49
b403b84 to
8b7236a
Compare
arnaudfnr
marked this pull request as ready for review
July 13, 2026 13:51
arnaudfnr
force-pushed
the
arnaudfnr/feat-add_bio_inventory
branch
from
July 16, 2026 06:48
8b7236a to
6d5a04f
Compare
Comment on lines
+57
to
+65
| let chartConfig: ChartConfig = {}; | ||
| chartData.forEach((element) => { | ||
| chartConfig = { | ||
| ...chartConfig, | ||
| [element.name]: { | ||
| label: element.name, | ||
| }, | ||
| }; | ||
| }); |
Collaborator
There was a problem hiding this comment.
Could use reduce here
const chartConfig = chartData.reduce((acc, element) => {
return {
...acc,
[element.name]: { label: element .name }
}
}, { } as ChartConfig);| @@ -1,24 +1,24 @@ | |||
| import type { LabelData } from "@entities/data"; | |||
Collaborator
There was a problem hiding this comment.
Might be good to add to the biome config the entities in the organizeImports below features (I arranged the imports regarding FSD orga)
Collaborator
There was a problem hiding this comment.
"organizeImports": {
"level": "on",
"options": {
"groups": [
[
":PACKAGE:",
":NODE:",
":PACKAGE_WITH_PROTOCOL:",
":BUN:",
"!@app/**",
"!@pages/**",
"!@widgets/**",
"!@features/**",
"!@entities/**",
"!@shared/**",
"!@lib/**",
"!@i18n",
"!@ui/**"
],
":BLANK_LINE:",
[":ALIAS:", "@/**"],
"@app/**",
":BLANK_LINE:",
"@pages/**",
":BLANK_LINE:",
"@widgets/**",
":BLANK_LINE:",
"@features/**",
":BLANK_LINE:",
"@entities/**",
":BLANK_LINE:",
"@shared/**",
"@lib/**",
"@i18n",
":BLANK_LINE:",
"@ui/**",
":BLANK_LINE:",
":PATH:"
]
}
},| @@ -0,0 +1,16 @@ | |||
| import { LAYERS } from "../shared/api/layers"; | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| import { LAYERS } from "../shared/api/layers"; | |
| import { LAYERS } from "@shared/api/layers"; |
| @@ -0,0 +1 @@ | |||
| export { useBioInventoryIndicatorElements as useBiodiversityIndicatorElements } from "./use-bioinventory-indicator-elements"; | |||
Collaborator
There was a problem hiding this comment.
Mmmmh I would rename when importing (on the consumer side), not exporting, it feels a bit weird to not follow its feature naming
Collaborator
Author
There was a problem hiding this comment.
yeah it 's just automatic when renaming a component...
| mapApiRef.current.setLayerSymbol({ | ||
| iconSize: getIconSize({}), | ||
| layerId: LAYERS.INVENTORY_BIO, | ||
| svg: pictoInventaire, |
Collaborator
There was a problem hiding this comment.
Maybe a different picto would be nice ?
Collaborator
Author
There was a problem hiding this comment.
I changed it , should be better now :)
david-bretaud-dev
approved these changes
Jul 18, 2026
david-bretaud-dev
left a comment
david-bretaud-dev
left a comment
Collaborator
There was a problem hiding this comment.
Great job ! Smallish improvements comments 🚀
arnaudfnr
force-pushed
the
arnaudfnr/feat-add_bio_inventory
branch
from
July 19, 2026 07:10
4618fb2 to
e7e5607
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.