fix(filters): Toggle visibility on cluster layers when updating source - #191
Merged
arnaudfnr merged 4 commits intoJul 18, 2026
Merged
Conversation
david-bretaud-dev
force-pushed
the
david-bretaud-dev/fix-link-filter-with-clustering-layers
branch
from
July 12, 2026 16:05
e40eb1b to
db11e96
Compare
arnaudfnr
reviewed
Jul 18, 2026
| }: { | ||
| layerId: string; | ||
| isActive: boolean; | ||
| showLayer?: (layerId: string) => void; |
Collaborator
There was a problem hiding this comment.
Why are showLayer and hideLayer optional ?
Collaborator
Author
There was a problem hiding this comment.
Because when initializing the map, in the mapContainerRef callback, in handleReady, we have to cope with the TS of the mapApiRef.current that can be undefined, thus the provided props are optional
// On first mount, sync the map state with the local storage state of "categories-filters"
syncInitialCategoriesFilters({
hideLayer: mapApiRef.current?.hideLayer,
showLayer: mapApiRef.current?.showLayer,
});
david-bretaud-dev
force-pushed
the
david-bretaud-dev/fix-link-filter-with-clustering-layers
branch
from
July 18, 2026 16:44
db11e96 to
e0f3462
Compare
arnaudfnr
approved these changes
Jul 18, 2026
arnaudfnr
deleted the
david-bretaud-dev/fix-link-filter-with-clustering-layers
branch
July 18, 2026 19:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #190
Coordo ts : dataforgoodfr/Coordonnees#98
See demo in coordo ts PR
Will need a coordo update in the package.json