Feature/grant_CREATE_to_collaborator by stacyho · Pull Request #204 · datahuborg/datahub

stacyho · 2016-12-16T06:09:28Z

Worked on Issue #157

Added ability for owner of a repository to grant CREATE privilege to collaborators.
Postgres problem: If a collaborator creates a table in another user's repository, only the collaborator can see / select that specific table.

RogerTangos · 2017-02-21T16:06:34Z

src/core/db/backend/pg.py

        params = tuple(map(lambda x: AsIs(x), params))
        res = self.execute_sql(query, params)
+
+        query = ('BEGIN;'


It appears that this grants CREATE to all users when added as collaborators. There's no check grantCreatePrivilege's value.

This also has one too many spaces, though that's more of a silly codeclimate issue.
https://codeclimate.com/github/datahuborg/datahub/pull/204

grant create privilege to collaborator

92bff1b

stacyho changed the title ~~grant create privilege to collaborator~~ Feature/grant create privilege to collaborator Dec 16, 2016

stacyho changed the title ~~Feature/grant create privilege to collaborator~~ Feature/grant_CREATE_to_collaborator Dec 16, 2016

RogerTangos reviewed Feb 21, 2017

View reviewed changes

Provide feedback