Add support for discovery configurations#21
Merged
Conversation
- Add `discovery_config` field to `SchemaDiscoveryRequest` - Add `FileDataDiscoveryRequest` + `FileDataDiscoveryOptions` models - Add `start_file_data_discovery_run()` for the file-data-discovery trigger
cph-datamasque
force-pushed
the
epic/discovery-config
branch
from
3b65b2b to
11ff50e
Compare
cph-datamasque
commented
Jun 23, 2026
cph-datamasque
force-pushed
the
epic/discovery-config
branch
from
11ff50e to
72c27a4
Compare
The server returns a 400 keyed under `discovery_config` when the referenced config is missing, archived, or not in `valid` validation state. Surface that as a specific exception subclass.
…nfig and run options
…ed-config triggers
…gration - Add `is_user_subscribed` to `MaskingRunRequest` (subscribe the requesting user to run notifications). - Add `auto_pull` / `auto_pull_branch` to `MaskingRunOptions` (refresh the ruleset from git before a run). - Surface `validation_error` (and `validation_error_type` for rulesets) on `Ruleset` and `RulesetLibrary`. - Expose git provenance as a nested `git` (`GitSnapshot`) field on both, collapsed from the flat `git_*` fields. - Exclude read-only fields (`id`, `is_valid`, `validation_error`, `git`, ...) from create/update request bodies. - Fix `SslZipFile` uploads to send the required `database_type=mysql` form field.
Names are unique only per type, so the by-name lookups need the type to identify a single config.
Copy `is_valid`/`validation_error` back from the server response, matching the ruleset-library client.
Require the fields the server always returns; type `connection` as `RunConnectionRef`.
cph-datamasque
force-pushed
the
epic/discovery-config
branch
from
a171cd6 to
edfa6e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.