feat(code-review): honor .opencodereview exclude globs when posting#2
Merged
Conversation
…globs OCR has no native path exclusion, so a PR touching a large vendored/tracked tree gets every upstream nit posted (and trips GitHub's secondary rate limit). Post-filter OCR output against the exclude globs already declared in <repo>/.opencodereview/rule.json before posting. No rule.json / no exclude = unchanged behavior.
vanducng
added a commit
to vanducng/skills
that referenced
this pull request
Jun 16, 2026
OCR has no native path exclusion, so the exclude field in rule.json was a no-op until dataplanelabs/workflows#2 post-filters by it. Skip vendored third-party directories; keep tracked skills themselves reviewable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ocr reviewhas no--exclude; theexcludefield in.opencodereview/rule.jsonis currently a no-op — verified viaocr review --preview). A PR touching a large vendored/tracked tree gets every upstream nit posted inline, and the volume trips GitHub's secondary rate limit, flipping the check red for an infra reason rather than a code one.Post review commentsstep now reads<repo>/.opencodereview/rule.json'sexcludearray and drops OCR comments whosepathmatches any glob before posting. Adds a smallglob -> RegExphelper (**,*,?) and logs how many were excluded (no silent truncation). No rule.json / noexclude-> behavior unchanged.excludefield; repos that do not set it are unaffected.Tests: glob matcher unit-checked locally · Docs: inline comment · Breaking: -