Skip to content

fix(code-review): used client-id for app token #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vanducng merged 2 commits into from
Jun 17, 2026
Merged

fix(code-review): used client-id for app token #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4334bd8
fix(code-review): use client-id for app token
vanducng Jun 17, 2026
f84a02f
fix(code-review): use client-id for app token
vanducng Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/code-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ name: Code Review (OpenCodeReview)
# OCR_LLM_URL, OCR_LLM_AUTH_TOKEN
# Optional:
# OCR_LLM_MODEL (default glm-5.2), OCR_LLM_USE_ANTHROPIC (default true)
# GH_APP_ID + GH_APP_MUNMIU_PRIVATE_KEY -> post comments as munmiu[bot]
# GH_APP_CLIENT_ID (or legacy GH_APP_ID) + GH_APP_MUNMIU_PRIVATE_KEY -> post comments as munmiu[bot]
# (falls back to github-actions[bot] when absent)

on:
Expand All @@ -28,6 +28,8 @@ on:
# github-actions[bot]. If absent/empty, falls back to GITHUB_TOKEN.
GH_APP_ID:
required: false
GH_APP_CLIENT_ID:
required: false
GH_APP_MUNMIU_PRIVATE_KEY:
required: false

Expand Down Expand Up @@ -129,9 +131,9 @@ jobs:
- name: Get munmiu app token
id: app-token
continue-on-error: true # absent app secrets / not installed → fall back to GITHUB_TOKEN
uses: actions/create-github-app-token@v3
uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3
with:
app-id: ${{ secrets.GH_APP_ID }}
client-id: ${{ secrets.GH_APP_CLIENT_ID || secrets.GH_APP_ID }}
private-key: ${{ secrets.GH_APP_MUNMIU_PRIVATE_KEY }}

- name: Post review comments to PR
Expand Down
Loading