Open
Conversation
jimdickinson
requested review from
bradfordcp,
johntrimble,
respringer and
sandoichi
as code owners
johntrimble
approved these changes
Jun 16, 2020
| This one has a lot of potential answers... | ||
|
|
||
| - `kubectl describe pod` and check the message for why the current nodes aren't being used. | ||
| - Did you pin any `racks` to a `zone` in a different region, or one without any k8s workers? |
Collaborator
There was a problem hiding this comment.
I'm about to say something about punctuation. I'm not a punctuation expert. I like to season my prose with punctuations until it looks right. However, the comma before "or" is, I think, unnecessary. This isn't a conjunction of two sentences, and it isn't a list of more than two things. There may be some other rule that necessitates a comma though, so I'm going to approve this PR anyway.
Member
|
Should this be in a draft state? I don't see why this is open pending a merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.