Skip to content

CNDB-15669: Fully off-heap memtable #2308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blambov wants to merge 24 commits into
base: main-5.0
Choose a base branch
from

Fix issues in payload cell tracking

80f3b79
Select commit
Loading
Failed to load commit list.
Open

CNDB-15669: Fully off-heap memtable #2308

Fix issues in payload cell tracking
80f3b79
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded May 22, 2026 in 6m 12s

Quality Gate passed

Issues
83 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
4.3% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 237 in src/java/org/apache/cassandra/db/tries/InMemoryDeletionAwareTrie.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reorder the modifiers to comply with the Java Language Specification. 

See more on https://sonarcloud.io/project/issues?id=cassandra-stargazer&issues=AZ4lqoNAek4mpMlU4E07&open=AZ4lqoNAek4mpMlU4E07&pullRequest=2308

Check warning on line 224 in src/java/org/apache/cassandra/db/tries/Cursor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove these useless parentheses. 

See more on https://sonarcloud.io/project/issues?id=cassandra-stargazer&issues=AZ4lqoMwek4mpMlU4E03&open=AZ4lqoMwek4mpMlU4E03&pullRequest=2308

Check warning on line 105 in src/java/org/apache/cassandra/db/partitions/TriePartitionUpdate.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Take the required action to fix the issue indicated by this comment. 

See more on https://sonarcloud.io/project/issues?id=cassandra-stargazer&issues=AZ4lqoKRek4mpMlU4E0m&open=AZ4lqoKRek4mpMlU4E0m&pullRequest=2308

Check warning on line 81 in src/java/org/apache/cassandra/db/rows/Cell.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"withUpdatedTimestampAndLocalDeletionTime" is defined in the "CellData" interface and can be removed from this class. 

See more on https://sonarcloud.io/project/issues?id=cassandra-stargazer&issues=AZ4lqoVBek4mpMlU4E1N&open=AZ4lqoVBek4mpMlU4E1N&pullRequest=2308

Check warning on line 118 in src/java/org/apache/cassandra/db/rows/Cell.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"localDeletionTimeAsUnsignedInt" is defined in the "CellData" interface and can be removed from this class. 

See more on https://sonarcloud.io/project/issues?id=cassandra-stargazer&issues=AZ4lqoVBek4mpMlU4E1R&open=AZ4lqoVBek4mpMlU4E1R&pullRequest=2308

Check warning on line 124 in src/java/org/apache/cassandra/db/rows/TrieBackedRow.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed. 

See more on https://sonarcloud.io/project/issues?id=cassandra-stargazer&issues=AZ4lqobMek4mpMlU4E1Y&open=AZ4lqobMek4mpMlU4E1Y&pullRequest=2308

Check failure on line 131 in src/java/org/apache/cassandra/db/ExpirationDateOverflowHandling.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use static access with "org.apache.cassandra.db.rows.CellData" for "MAX_DELETION_TIME_2038_LEGACY_CAP". 

See more on https://sonarcloud.io/project/issues?id=cassandra-stargazer&issues=AZ4lqocYek4mpMlU4E1f&open=AZ4lqocYek4mpMlU4E1f&pullRequest=2308

Check warning on line 177 in src/java/org/apache/cassandra/db/tries/InMemoryDeletionAwareTrie.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add the "@Override" annotation above this method signature 

See more on https://sonarcloud.io/project/issues?id=cassandra-stargazer&issues=AZ4lqoNAek4mpMlU4E06&open=AZ4lqoNAek4mpMlU4E06&pullRequest=2308

Check warning on line 109 in src/java/org/apache/cassandra/db/tries/TrieDumperWithPath.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reorder the modifiers to comply with the Java Language Specification. 

See more on https://sonarcloud.io/project/issues?id=cassandra-stargazer&issues=AZ4lqoOvek4mpMlU4E1B&open=AZ4lqoOvek4mpMlU4E1B&pullRequest=2308

Check failure on line 93 in src/java/org/apache/cassandra/db/rows/Cell.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove usage of generic wildcard type. 

See more on https://sonarcloud.io/project/issues?id=cassandra-stargazer&issues=AZ4lqoVBek4mpMlU4E1P&open=AZ4lqoVBek4mpMlU4E1P&pullRequest=2308

Check warning on line 72 in test/unit/org/apache/cassandra/db/partitions/AffectedColumnCountTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "c2" private field. 

See more on https://sonarcloud.io/project/issues?id=cassandra-stargazer&issues=AZ4mZXUiUXak47t1dD2-&open=AZ4mZXUiUXak47t1dD2-&pullRequest=2308

Check warning on line 82 in src/java/org/apache/cassandra/db/rows/TrieBackedRow.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Override the "equals" method in this class. 

See more on https://sonarcloud.io/project/issues?id=cassandra-stargazer&issues=AZ4lqobMek4mpMlU4E1X&open=AZ4lqobMek4mpMlU4E1X&pullRequest=2308

Check failure on line 97 in src/java/org/apache/cassandra/index/transactions/UpdateTransaction.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=cassandra-stargazer&issues=AZ4lqoE1ek4mpMlU4E0f&open=AZ4lqoE1ek4mpMlU4E0f&pullRequest=2308

Check warning on line 83 in src/java/org/apache/cassandra/db/ExpirationDateOverflowHandling.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unnecessary cast to "long". 

See more on https://sonarcloud.io/project/issues?id=cassandra-stargazer&issues=AZ4lqocYek4mpMlU4E1e&open=AZ4lqocYek4mpMlU4E1e&pullRequest=2308

Check warning on line 84 in src/java/org/apache/cassandra/db/partitions/PartitionUpdate.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Take the required action to fix the issue indicated by this comment. 

See more on https://sonarcloud.io/project/issues?id=cassandra-stargazer&issues=AZ4lqoL4ek4mpMlU4E0z&open=AZ4lqoL4ek4mpMlU4E0z&pullRequest=2308

Check warning on line 137 in src/java/org/apache/cassandra/db/tries/RangeCursor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the type specification in this constructor call with the diamond operator ("<>"). (sonar.java.source not set. Assuming 7 or greater.) 

See more on https://sonarcloud.io/project/issues?id=cassandra-stargazer&issues=AZ4lqoNqek4mpMlU4E0-&open=AZ4lqoNqek4mpMlU4E0-&pullRequest=2308

Check warning on line 46 in src/java/org/apache/cassandra/db/partitions/TriePartitionUpdater.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make colUpdateTimeDelta a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=cassandra-stargazer&issues=AZ4lqoLTek4mpMlU4E0q&open=AZ4lqoLTek4mpMlU4E0q&pullRequest=2308

Check warning on line 91 in src/java/org/apache/cassandra/db/rows/Cell.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"withSkippedValue" is defined in the "CellData" interface and can be removed from this class. 

See more on https://sonarcloud.io/project/issues?id=cassandra-stargazer&issues=AZ4lqoVBek4mpMlU4E1O&open=AZ4lqoVBek4mpMlU4E1O&pullRequest=2308

Check failure on line 389 in src/java/org/apache/cassandra/index/sai/memory/TrieMemoryIndex.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use static access with "org.apache.cassandra.db.tries.InMemoryBaseTrie" for "UpsertTransformer". 

See more on https://sonarcloud.io/project/issues?id=cassandra-stargazer&issues=AZ4lqoDEek4mpMlU4E0b&open=AZ4lqoDEek4mpMlU4E0b&pullRequest=2308

Check failure on line 197 in src/java/org/apache/cassandra/db/partitions/TriePartitionUpdater.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove usage of generic wildcard type. 

See more on https://sonarcloud.io/project/issues?id=cassandra-stargazer&issues=AZ4lqoLTek4mpMlU4E0x&open=AZ4lqoLTek4mpMlU4E0x&pullRequest=2308

Check failure on line 67 in src/java/org/apache/cassandra/db/DeletionTime.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use static access with "org.apache.cassandra.db.rows.CellData" for "MAX_DELETION_TIME_UNSIGNED_INTEGER". 

See more on https://sonarcloud.io/project/issues?id=cassandra-stargazer&issues=AZ4lqocAek4mpMlU4E1a&open=AZ4lqocAek4mpMlU4E1a&pullRequest=2308

Check warning on line 59 in src/java/org/apache/cassandra/db/partitions/TriePartitionUpdaterStage3.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make partitionsAdded a static final constant or non-public and provide accessors if needed. 

See more on https://sonarcloud.io/project/issues?id=cassandra-stargazer&issues=AZ4lqoK5ek4mpMlU4E0n&open=AZ4lqoK5ek4mpMlU4E0n&pullRequest=2308

Check failure on line 436 in src/java/org/apache/cassandra/index/sai/memory/TrieMemoryIndex.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use static access with "org.apache.cassandra.db.tries.InMemoryBaseTrie" for "UpsertTransformer". 

See more on https://sonarcloud.io/project/issues?id=cassandra-stargazer&issues=AZ4lqoDEek4mpMlU4E0c&open=AZ4lqoDEek4mpMlU4E0c&pullRequest=2308

Check warning on line 104 in src/java/org/apache/cassandra/db/partitions/TriePartitionUpdater.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Immediately return this expression instead of assigning it to the temporary variable "merged". 

See more on https://sonarcloud.io/project/issues?id=cassandra-stargazer&issues=AZ4lqoLTek4mpMlU4E0r&open=AZ4lqoLTek4mpMlU4E0r&pullRequest=2308

Check failure on line 284 in src/java/org/apache/cassandra/db/tries/InMemoryDeletionAwareTrie.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 26 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=cassandra-stargazer&issues=AZ4lqoNAek4mpMlU4E08&open=AZ4lqoNAek4mpMlU4E08&pullRequest=2308
View more details on SonarQubeCloud