Skip to content

HCD-200: Incremental repair is unable to lock sstables under load#2360

Merged
blambov merged 3 commits into
main-5.0from
HCD-200-5.0
May 13, 2026
Merged

HCD-200: Incremental repair is unable to lock sstables under load#2360
blambov merged 3 commits into
main-5.0from
HCD-200-5.0

Conversation

@blambov
Copy link
Copy Markdown

@blambov blambov commented Apr 28, 2026 •
edited by atlassian Bot
Loading

HCD-200

Followup to 907af99 that updates the scheduled tasks interruption to apply task priorities.

What is the issue

...

What does this PR fix and why was it fixed

...

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@blambov
HCD-200: Incremental repair is unable to lock sstables under load (#2266
db49aaf 
)

[HCD-200](https://datastax.jira.com/browse/HCD-200)

Changes the tracking of compaction tasks to include scheduled in
addition to active tasks by introducing a new queue where
`AbstractCompactionTask`s register themselves.

When the tasks execute, `CompactionTask`s move from the scheduled tasks
to the active operations list. Other types of tasks are expected to finish quickly
and are removed from the scheduled tasks when they complete.

`runWithCompactionsDisabled` cancels tasks in both lists and should now
be able to reliably cancel all compactions in flight.

[HCD-200]:
https://datastax.jira.com/browse/HCD-200
@blambov blambov requested a review from driftx May 12, 2026 08:18
@blambov blambov marked this pull request as ready for review May 12, 2026 08:19
driftx
driftx approved these changes May 12, 2026
View reviewed changes
Comment thread src/java/org/apache/cassandra/db/ColumnFamilyStore.java Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 13, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@plpesvc-ds
Copy link
Copy Markdown

plpesvc-ds commented May 13, 2026

❌ Build ds-cassandra-pr-gate/PR-2360 rejected by Butler

12 regressions found
See build details here

Found 12 new test failures

Test Explanation Runs Upstream
hintedhandoff_test.TestHintedHandoff.test_hintedhandoff_disagreement (offheap-bti-scm-hcd_1) NEW 🔴🔴 0 / 30
paxos_test.TestPaxos.test_replica_availability (offheap-bti-scm-hcd_1) NEW 🔴🔴 0 / 30
replica_side_filtering_test.TestAllowFiltering.test_count (offheap-bti-scm-hcd_1) NEW 🔴🔴 0 / 30
replica_side_filtering_test.TestAllowFiltering.test_update_on_collection (offheap-bti-scm-hcd_1) NEW 🔴🔴 0 / 30
replica_side_filtering_test.TestAllowFiltering.test_update_on_skinny_table (offheap-bti-scm-hcd_1) NEW 🔴🔴 0 / 30
replica_side_filtering_test.TestAllowFiltering.test_update_on_static_column_with_empty_partition (offheap-bti-scm-hcd_1) NEW 🔴🔴 0 / 30
replica_side_filtering_test.TestAllowFiltering.test_update_on_static_column_with_not_empty_partition (offheap-bti-scm-hcd_1) NEW 🔴🔴 0 / 30
replica_side_filtering_test.TestAllowFiltering.test_update_on_wide_table (offheap-bti-scm-hcd_1) NEW 🔴🔴 0 / 30
sstable_generation_loading_test.TestSSTableGenerationAndLoadingLegacyIndex.test_sstableloader_with_failing_2i (offheap-bti-scm-hcd_1) NEW 🔴🔴 0 / 30
o.a.c.index.sai.cql.VectorCompaction100dTest.testOneToManyCompaction[version=ec enableNVQ=true] () NEW 🔴⚪ 0 / 30
o.a.c.index.sai.cql.VectorKeyRestrictedOnPartitionTest.partitionRestrictedTest[version=db enableNVQ=false enableFused=false] () NEW 🔴⚪ 0 / 30
o.a.c.index.sai.cql.VectorSiftSmallTest.testRerankKZeroOrderMatchesFullPrecisionSimilarity[version=ed enableNVQ=true enableFused=false] () NEW 🔴⚪ 0 / 30

Found 14 known test failures

@blambov
Copy link
Copy Markdown
Author

blambov commented May 13, 2026 •
edited
Loading

I don't see any test failures that could be regressions, moving to commit.

@blambov blambov merged commit b154024 into main-5.0 May 13, 2026
4 of 6 checks passed
@blambov blambov deleted the HCD-200-5.0 branch May 13, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@driftx driftx driftx approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blambov @plpesvc-ds @driftx