CNDB-17107 Use SCM HCD_1 as default for CC5 junit tests#2406
Merged
Conversation
Checklist before you submit for review
|
driftx
approved these changes
May 8, 2026
driftx
reviewed
May 11, 2026
Tests using CIDR permissions and identity-to-role mapping (5.0+ features) were failing in compatibility mode because underlying tables don't exist. Fixed by: - Skipping test classes entirely dedicated to 5.0 features and individual 5.0 test methods in mixed test classes - Adding guards in manager classes to prevent InvalidRequestException and NPE during test setup when tables/statements don't exist
…les when SCM is based on 4.0
…ndraRelevantProperties instead of DatabaseDescriptor to get the SCM
…se based on the storage compatibility mode.
…n guards Fixes the test framework (CQLTester) to conditionally initialize CIDR components based on Storage Compatibility Mode, matching production behavior in StorageService.doAuthSetup().
…d memtables in SCM 4 mode
…ptor when SCM is 4.0
|
❌ Build ds-cassandra-pr-gate/PR-2406 rejected by Butler5 regressions found Found 5 new test failuresFound 9 known test failures |
driftx
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the issue
Fixes #17107
What does this PR fix and why was it fixed
Changes the default Storage Compatibility Mode (SCM) value used in unit tests from
NONEtoHCD_1to ensure that by default we are testing with the compatibility mode we plan to deploy in Astra DB.Since #17096 Jenkins builds have the ability to specify additional SCM modes, e.g.
scm-noneso that builds can cover any or multiple values. Note: the related #17756 updates the jenkins pipeline to useHCD_1instead ofCC_4.