Skip to content

CNDB-17789: Fix flaky SAI query context TTL assertions #2417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
driftx merged 1 commit into from
May 14, 2026
Merged

CNDB-17789: Fix flaky SAI query context TTL assertions #2417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions test/unit/org/apache/cassandra/index/sai/QueryContextTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@

public class QueryContextTest extends SAITester.Versioned
{
private static final int EXPIRING_ROW_TTL_SECONDS = 5;
private static final int EXPIRING_ROW_WAIT_SECONDS = EXPIRING_ROW_TTL_SECONDS + 1;

@Test
public void testSkinnyTable()
{
Expand Down Expand Up @@ -209,11 +212,11 @@ public void testSkinnyTable()

// insert some data using TTLs
execute("INSERT INTO %s (k, a, b) VALUES (0, 0, 0)");
execute("INSERT INTO %s (k, a, b) VALUES (1, 1, 1) USING TTL 1");
execute("INSERT INTO %s (k, a, b) VALUES (1, 1, 1) USING TTL " + EXPIRING_ROW_TTL_SECONDS);
execute("INSERT INTO %s (k, a, b) VALUES (2, 0, 0)");
execute("INSERT INTO %s (k, a, b) VALUES (3, 1, 1) USING TTL 1");
execute("INSERT INTO %s (k, a, b) VALUES (3, 1, 1) USING TTL " + EXPIRING_ROW_TTL_SECONDS);
flush();
Uninterruptibles.sleepUninterruptibly(2, TimeUnit.SECONDS);
Uninterruptibles.sleepUninterruptibly(EXPIRING_ROW_WAIT_SECONDS, TimeUnit.SECONDS);
snapshot = queryContext("SELECT * FROM %s WHERE a >= 0 ALLOW FILTERING",
row(0, 0, 0),
row(2, 0, 0));
Expand Down Expand Up @@ -471,13 +474,13 @@ public void testWideTableWithoutStatics()

// insert some data using TTLs
execute("INSERT INTO %s (k, c, a, b) VALUES (0, 0, 0, 0)");
execute("INSERT INTO %s (k, c, a, b) VALUES (0, 1, 1, 1) USING TTL 1");
execute("INSERT INTO %s (k, c, a, b) VALUES (0, 1, 1, 1) USING TTL " + EXPIRING_ROW_TTL_SECONDS);
execute("INSERT INTO %s (k, c, a, b) VALUES (0, 2, 0, 0)");
execute("INSERT INTO %s (k, c, a, b) VALUES (1, 0, 0, 0)");
execute("INSERT INTO %s (k, c, a, b) VALUES (1, 1, 1, 1)");
execute("INSERT INTO %s (k, c, a, b) VALUES (1, 2, 0, 0) USING TTL 1");
execute("INSERT INTO %s (k, c, a, b) VALUES (1, 2, 0, 0) USING TTL " + EXPIRING_ROW_TTL_SECONDS);
flush();
Uninterruptibles.sleepUninterruptibly(2, TimeUnit.SECONDS);
Uninterruptibles.sleepUninterruptibly(EXPIRING_ROW_WAIT_SECONDS, TimeUnit.SECONDS);
snapshot = queryContext("SELECT * FROM %s WHERE a >= 0 ALLOW FILTERING",
row(0, 0, 0, 0),
row(0, 2, 0, 0),
Expand Down Expand Up @@ -656,16 +659,16 @@ public void testWideTableScoreOrdered()
assertEquals(0, snapshot.rowTombstonesFetched);

// insert some data using TTLs
execute("INSERT INTO %s (k, c, n, v) VALUES (0, 0, 0, [0, 0]) USING TTL 1");
execute("INSERT INTO %s (k, c, n, v) VALUES (0, 0, 0, [0, 0]) USING TTL " + EXPIRING_ROW_TTL_SECONDS);
execute("INSERT INTO %s (k, c, n, v) VALUES (0, 1, 1, [1, 1])");
execute("INSERT INTO %s (k, c, n, v) VALUES (0, 2, 0, [0, 0])");
execute("INSERT INTO %s (k, c, n, v) VALUES (0, 3, 1, [1, 1])");
execute("INSERT INTO %s (k, c, n, v) VALUES (1, 0, 0, [0, 0])");
execute("INSERT INTO %s (k, c, n, v) VALUES (1, 1, 1, [1, 1]) USING TTL 1");
execute("INSERT INTO %s (k, c, n, v) VALUES (1, 1, 1, [1, 1]) USING TTL " + EXPIRING_ROW_TTL_SECONDS);
execute("INSERT INTO %s (k, c, n, v) VALUES (1, 2, 0, [0, 0])");
execute("INSERT INTO %s (k, c, n, v) VALUES (1, 3, 1, [1, 1])");
flush();
Uninterruptibles.sleepUninterruptibly(2, TimeUnit.SECONDS);
Uninterruptibles.sleepUninterruptibly(EXPIRING_ROW_WAIT_SECONDS, TimeUnit.SECONDS);
snapshot = queryContext("SELECT * FROM %s ORDER BY v ANN OF [0, 0] LIMIT 10",
row(1, 0, 0, vector(0, 0)),
row(1, 2, 0, vector(0, 0)),
Expand Down Expand Up @@ -959,16 +962,16 @@ public void testWideTableWithStatics()
assertEquals(0, snapshot.rowTombstonesFetched);

// insert some data using TTLs
execute("INSERT INTO %s (k, c, a, b, s) VALUES (0, 0, 0, 0, 0) USING TTL 1");
execute("INSERT INTO %s (k, c, a, b, s) VALUES (0, 0, 0, 0, 0) USING TTL " + EXPIRING_ROW_TTL_SECONDS);
execute("INSERT INTO %s (k, c, a, b) VALUES (0, 1, 1, 1)");
execute("INSERT INTO %s (k, c, a, b) VALUES (0, 2, 0, 0)");
execute("INSERT INTO %s (k, c, a, b) VALUES (0, 3, 1, 1)");
execute("INSERT INTO %s (k, c, a, b, s) VALUES (1, 0, 0, 0, 1)");
execute("INSERT INTO %s (k, c, a, b) VALUES (1, 1, 1, 1)");
execute("INSERT INTO %s (k, c, a, b) VALUES (1, 2, 0, 0) USING TTL 1");
execute("INSERT INTO %s (k, c, a, b) VALUES (1, 2, 0, 0) USING TTL " + EXPIRING_ROW_TTL_SECONDS);
execute("INSERT INTO %s (k, c, a, b) VALUES (1, 3, 1, 1)");
flush();
Uninterruptibles.sleepUninterruptibly(2, TimeUnit.SECONDS);
Uninterruptibles.sleepUninterruptibly(EXPIRING_ROW_WAIT_SECONDS, TimeUnit.SECONDS);
snapshot = queryContext("SELECT k,c,a,b,s FROM %s WHERE a >= 0",
row(0, 1, 1, 1, null),
row(0, 2, 0, 0, null),
Expand Down
Loading