CNDB-17831: Use 2038 max deletion time in HCD_1#2424
Merged
Conversation
Checklist before you submit for review
|
djatnieks
requested changes
May 18, 2026
Member
djatnieks
left a comment
There was a problem hiding this comment.
I think this change is breaking testImprovedMaxTTL - maybe the Assume needs to be updated to something like this?
Assume.assumeFalse(DatabaseDescriptor.getStorageCompatibilityMode().isBefore(5));
Author
|
Yep, good call, added. |
|
❌ Build ds-cassandra-pr-gate/PR-2424 rejected by Butler3 regressions found Found 3 new test failuresFound 8 known test failures |
djatnieks
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What is the issue
Max deletion time is 2038 in 4.0 and should be used in HCD_1 mode
What does this PR fix and why was it fixed
Use 2038 max deletion time in HCD_1