Skip to content

CNDB-17831: Use 2038 max deletion time in HCD_1#2424

Merged
driftx merged 2 commits into
main-5.0from
CNDB-17831
May 19, 2026
Merged

CNDB-17831: Use 2038 max deletion time in HCD_1#2424
driftx merged 2 commits into
main-5.0from
CNDB-17831

Conversation

@driftx
Copy link
Copy Markdown

@driftx driftx commented May 18, 2026

What is the issue

Max deletion time is 2038 in 4.0 and should be used in HCD_1 mode

What does this PR fix and why was it fixed

Use 2038 max deletion time in HCD_1

@github-actions
Copy link
Copy Markdown

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR and ticket in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the IBM copyright header instead of the Apache License one (no DataStax copyright any longer)

Copy link
Copy Markdown
Member

@djatnieks djatnieks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is breaking testImprovedMaxTTL - maybe the Assume needs to be updated to something like this?
Assume.assumeFalse(DatabaseDescriptor.getStorageCompatibilityMode().isBefore(5));

@driftx
Copy link
Copy Markdown
Author

driftx commented May 18, 2026

Yep, good call, added.

@sonarqubecloud
Copy link
Copy Markdown

@plpesvc-ds
Copy link
Copy Markdown

❌ Build ds-cassandra-pr-gate/PR-2424 rejected by Butler


3 regressions found
See build details here


Found 3 new test failures

Test Explanation Runs Upstream
replica_side_filtering_test.TestAllowFiltering.test_consistent_skinny_table (offheap-bti-scm-hcd_1) REGRESSION 🔵🔴 0 / 30
o.a.c.index.sai.cql.VectorCompaction100dTest.testZeroOrOneToManyCompaction[version=ec enableNVQ=false] () NEW 🔴 0 / 30
o.a.c.index.sai.cql.VectorSiftSmallTest.testRerankKZeroOrderMatchesFullPrecisionSimilarity[version=fa enableNVQ=false enableFused=false] () NEW 🔴 0 / 30

Found 8 known test failures

@driftx driftx merged commit 67c77c1 into main-5.0 May 19, 2026
4 of 6 checks passed
@driftx driftx deleted the CNDB-17831 branch May 19, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants