CNDB-17291: Fix SlowSAIQueryLoggerTest#2427
Open
adelapena wants to merge 1 commit into
Open
Conversation
Enable term stats in this dtest, same as in utests extending SAITester. This was broken by CNDB-17275.
Checklist before you submit for review
|
|
❌ Build ds-cassandra-pr-gate/PR-2427 rejected by Butler4 regressions found Found 4 new test failures
Found 3 known test failures |
pkolaczk
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What is the issue
CNDB-17275 broke
SlowSAIQueryLoggerTestby disabling the use of term stats by the query optimizer by default. While disabled in production, the usage of term stats is enabled by default for utests extendingSAITester. However, theSlowSAIQueryLoggerTestdtest doesn't extendSAITester, so it broke after that change. That first failure can be seen in the CI results for CNDB-17275: #2290 (comment)What does this PR fix and why was it fixed
Enable
SAI_QUERY_OPTIMIZATION_USE_TERM_STATISTICSinSlowSAIQueryLoggerTestto preserve the original behaviour.