Skip to content

CNDB-17291: Fix SlowSAIQueryLoggerTest#2427

Open
adelapena wants to merge 1 commit into
mainfrom
CNDB-17291-main
Open

CNDB-17291: Fix SlowSAIQueryLoggerTest#2427
adelapena wants to merge 1 commit into
mainfrom
CNDB-17291-main

Conversation

@adelapena
Copy link
Copy Markdown

What is the issue

CNDB-17275 broke SlowSAIQueryLoggerTest by disabling the use of term stats by the query optimizer by default. While disabled in production, the usage of term stats is enabled by default for utests extending SAITester. However, the SlowSAIQueryLoggerTest dtest doesn't extend SAITester, so it broke after that change. That first failure can be seen in the CI results for CNDB-17275: #2290 (comment)

What does this PR fix and why was it fixed

Enable SAI_QUERY_OPTIMIZATION_USE_TERM_STATISTICS in SlowSAIQueryLoggerTest to preserve the original behaviour.

Enable term stats in this dtest, same as in utests extending SAITester. This was broken by CNDB-17275.
@adelapena adelapena self-assigned this May 19, 2026
@github-actions
Copy link
Copy Markdown

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR and ticket in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the IBM copyright header instead of the Apache License one (no DataStax copyright any longer)

@sonarqubecloud
Copy link
Copy Markdown

@plpesvc-ds
Copy link
Copy Markdown

❌ Build ds-cassandra-pr-gate/PR-2427 rejected by Butler


4 regressions found
See build details here


Found 4 new test failures

Test Explanation Runs Upstream
o.a.c.index.sai.cql.VectorCompaction100dTest.testPQRefine[version=ec enableNVQ=false] REGRESSION 🔴 0 / 30
o.a.c.index.sai.cql.VectorKeyRestrictedOnPartitionTest.partitionRestrictedWidePartitionBqCompressedTest[version=ca enableNVQ=false enableFused=false] REGRESSION 🔴 0 / 30
o.a.c.index.sai.cql.VectorSiftSmallTest.testSiftSmall[version=fa enableNVQ=false enableFused=false] REGRESSION 🔴 0 / 30
o.a.c.index.sai.cql.VectorTypeTest.lwtTest[version=ca enableNVQ=false enableFused=false] REGRESSION 🔴 0 / 30

Found 3 known test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants