feat: centralize all constants in constants.ts by ritoban23 · Pull Request #231 · datazip-inc/olake-ui

ritoban23 · 2025-10-15T12:06:01Z

Description

This PR centralizes all scattered constants throughout the codebase into a single constants.ts file. Previously, constants like connector types, status values, tab types, and default values were hardcoded in multiple files, leading to maintenance issues and potential inconsistencies.

Key Changes:

Added 5 new constant groups to ui/src/utils/constants.ts:
- STREAM_FILTERS - Filter options for job streams
- CONNECTOR_TYPE_MAP - Mapping between lowercase and proper case connector names
- DEFAULT_CONNECTORS - Default connector values for sources and destinations
- TAB_TYPE_VALUES - Tab navigation constants with proper TypeScript literal types
- STATUS_VALUES - Status constants for entities and jobs
Updated 10 component files to import and use centralized constants instead of hardcoded strings

Fixes #152

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Build verification - pnpm run build completes successfully
Linting verification - pnpm run lint passes with 0 errors and 0 warnings
TypeScript compilation - All type errors resolved, proper literal types enforced
Import verification - All components successfully import and use centralized constants
Functionality testing - Application starts and navigates correctly with new constants

Test Configuration:

Node.js environment with pnpm package manager
TypeScript strict mode enabled
ESLint with max-warnings set to 0
Vite build system

Screenshots or Recordings

No visual changes - this is an internal refactoring that improves code organization and maintainability.

Related PR's (If Any):

* chore: add comments * chore: 🚨 lint fix

…atazip-inc#195) * feat: add error logs i check conenction for source and destination * fix: parse json message as string * chore: update response key * chore: refactor * chore: remove logEntry struct * fix: log parsing * fix: log parsing * fix: logs parsing logic * docs: updated api contract

…ogs-in-test-connection feat: show error logs in test connection

ritoban23 · 2025-10-15T13:16:34Z

@deepanshupal09-datazip Thanks for the feedback! some quick questions... should I then create a separate enums.ts file or keep them in constants.ts, replace DEFAULT_CONNECTORS.SOURCE with CONNECTOR_TYPES.SOURCE_DEFAULT_CONNECTOR (which alread yexists) or hardcode "MongoDB", also should the eums use singluar or plural names?

* test: ✅ base setup for automation testing using playwright , add test cases fro major flows * fix: integration workflow changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * fix: ci changes * test: add postgres flow * fix: lint changes * test: add iceberg specific test * fix: tests * fix: stream name * fix: test fix * fix: test fix * fix: test fix * fix: test fix * fix: changes * fix: ci changes * fix: ci changes * fix: ci changes * test: fail test on test connection failure * fix: ci changes * fix: changes * fix: changes * fix: changes * fix: changes * fix: changes * fix: changes * fix: test fix * fix: changes * fix: changes * fix: test-data fix * fix: test-data fix * fix: changes * fix: changes * fix: changes * fix: host and port changes * fix: changes * fix: change * test: login test updated * test: refactor create source and destination page * test: refactor tests * fix: test fix * fix: changes * fix: fix changes * fix: changes * fix: changes * fix: review changes * refactor: refactor tests to use authenticated state of playwright * fix: changes * docs: update tests readme * test: intercept and log destination spec response * docs: update readme * fix: update timeouts for playwright tests * test: update readme * fix: add retries in playwright config * test: fix timeout duration * fix: update readme * test: add connector data test-id * fix: resolve comments * refactor(test): make and use enums instead of strings * fix: fix test data builder * fix: test data job name * fix: add todo --------- Co-authored-by: Duke Dhal <duke@datazip.io> Co-authored-by: deepanshupal09-datazip <deepanshu@datazip.io>

deepanshupal09-datazip · 2025-10-17T12:43:07Z

@deepanshupal09-datazip Thanks for the feedback! some quick questions... should I then create a separate enums.ts file or keep them in constants.ts, replace DEFAULT_CONNECTORS.SOURCE with CONNECTOR_TYPES.SOURCE_DEFAULT_CONNECTOR (which alread yexists) or hardcode "MongoDB", also should the eums use singluar or plural names?

Hi @ritoban23, sorry for the late reply, been caught up in some work. Answer to your questions:

enums should be singular like CONNECTOR_TYPE
create a folder in ui folder root named enums where all enums would be stored, name the enum file appropriately along with a index.ts for clean exports.
no need to make a separate constant for default connector, just hardcode them directly like SourceConnector.MongoDB

Also make separate enums for source and destination connector like SourceConnector and DestinationConnector... you may refer this file

deepanshupal09-datazip · 2025-10-21T15:49:43Z

@@ -0,0 +1,10 @@
+export enum StatusValue {


The name StatusValue is unclear. Since it’s used on the Sources page, please rename it to something more descriptive to improve readability.

Also there are only two status in Sources page... Active and Inactive
We don't need these many statuses, please remove useless values

Also, please use this enum in Destinations page as well for consistency.

deepanshupal09-datazip · 2025-10-21T16:04:37Z

@@ -0,0 +1,6 @@
+export enum TabType {


This enum is currently being used in both StreamConfiguration and SourceEdit. Since these components serve different purposes and contexts, sharing the same enum may lead to confusion or unintended coupling in the future. It would be better to define separate enums for each component to maintain clear separation of concerns and improve maintainability.

Also, please ensure that each enum is named appropriately (e.g., StreamTab, SourceTab) so that its purpose and scope are clear.

deepanshupal09-datazip · 2025-10-21T16:11:01Z

 			const connectorTypeMap: Record<string, string> = {
-				mongodb: "MongoDB",
-				postgres: "Postgres",
-				mysql: "MySQL",
-				oracle: "Oracle",
+				[SourceConnector.MONGODB.toLowerCase()]: SourceConnector.MONGODB,
+				[SourceConnector.POSTGRES.toLowerCase()]: SourceConnector.POSTGRES,
+				[SourceConnector.MYSQL.toLowerCase()]: SourceConnector.MYSQL,
+				[SourceConnector.ORACLE.toLowerCase()]: SourceConnector.ORACLE,


Suggested change

const connectorTypeMap: Record<string, string> = {

mongodb: "MongoDB",

postgres: "Postgres",

mysql: "MySQL",

oracle: "Oracle",

[SourceConnector.MONGODB.toLowerCase()]: SourceConnector.MONGODB,

[SourceConnector.POSTGRES.toLowerCase()]: SourceConnector.POSTGRES,

[SourceConnector.MYSQL.toLowerCase()]: SourceConnector.MYSQL,

[SourceConnector.ORACLE.toLowerCase()]: SourceConnector.ORACLE,

const SourceConnectorLabel: Record<string, string> = {

[SourceConnector.MONGODB]: "MongoDB",

[SourceConnector.POSTGRES]: "Postgres",

[SourceConnector.MYSQL]: "MySQL",

[SourceConnector.ORACLE]: "Oracle",

}

Also, please move this to the constants file

Also, please do the same thing for DestinationEdit as well

* Added success message on Job History refetch * Update ui/src/modules/jobs/pages/JobHistory.tsx Co-authored-by: deepanshupal09-datazip <deepanshu@datazip.io> --------- Co-authored-by: vikash choudhary <vikash@datazip.io> Co-authored-by: deepanshupal09-datazip <deepanshu@datazip.io>

…datazip-inc#216) * fix: replace deprecated Phosphor icons with latest *Icon alternatives * fix: update Phosphor icons to latest alternatives in DestinationEdit and SourceEdit components and fix Lint issue * refactor: remove EditSourceModal * fix: update icon import --------- Co-authored-by: vikash choudhary <vikash@datazip.io>

* feat: add append only mode in ui * fix: data filter bug * fix: fix color of append only mode switch * fix: add custom option in all streams ingestion mode change * fix: use clsx for conditional styling * fix: fix icons

…>SourceStatus, centralize connector labels in constants

ritoban23 · 2025-10-29T13:38:01Z

@deepanshupal09-datazip I have addressed all the feedbacks . apologies for the late update, thanks!

deepanshupal09-datazip · 2025-10-29T13:55:54Z

@deepanshupal09-datazip I have addressed all the feedbacks . apologies for the late update, thanks!

No worries... linter is failing... please run pnpm lint:fix in ui folder to fix the errors

deepanshupal09-datazip · 2025-10-29T14:10:54Z

Also, please avoid using force push in the future. When you force pushed, the previous commits (and my comments on them) were removed, which makes it difficult to track changes since the last review. Force pushing disrupts the review process and removes useful context from the commit history. Now I'll have to review from the start, which will take more time.

Please avoid doing that unless it's absolutely necessary.

ritoban23 · 2025-10-29T15:08:52Z

@deepanshupal09-datazip I'll make sure to not do that from next time, I usually force push after rebasing ,didn't realize I shouldn't do it when i was updating after you merged the staging branch

deepanshupal09-datazip and others added 10 commits October 1, 2025 16:31

feat: show error logs in test connection in source and destination

5da3883

fix: fix test connection fail modal

b63bece

Merge branch 'staging' into feat/show-error-logs-in-test-connection

772ae8a

Merge branch 'staging' into feat/show-error-logs-in-test-connection

4567a14

fix: resolve comments

a20e009

fix: merge conflicts

0e1fc65

chore: add comments (datazip-inc#224)

89034f5

* chore: add comments * chore: 🚨 lint fix

Merge branch 'staging' into feat/show-error-logs-in-test-connection

826a526

Merge pull request datazip-inc#208 from datazip-inc/feat/show-error-l…

526d35b

…ogs-in-test-connection feat: show error logs in test connection

ritoban23 mentioned this pull request Oct 15, 2025

feat: centralize all constants in constants.ts #230

Closed

9 tasks

deepanshupal09-datazip requested changes Oct 15, 2025

View reviewed changes

Comment thread ui/src/utils/constants.ts Outdated

Comment thread ui/src/utils/constants.ts Outdated

Comment thread ui/src/utils/constants.ts Outdated

Comment thread ui/src/utils/constants.ts Outdated

Comment thread ui/src/utils/constants.ts Outdated

ritoban23 force-pushed the feat/centralize-constants branch from b962dff to 955c859 Compare October 17, 2025 14:45

deepanshupal09-datazip requested changes Oct 21, 2025

View reviewed changes

Sarthak2845 and others added 2 commits October 24, 2025 16:37

deepanshupal09-datazip added the hacktoberfest Issues open for Hacktoberfest contributors label Oct 28, 2025

deepanshupal09-datazip and others added 4 commits October 29, 2025 13:09

feat: append only mode (datazip-inc#232)

4cf9938

* feat: add append only mode in ui * fix: data filter bug * fix: fix color of append only mode switch * fix: add custom option in all streams ingestion mode change * fix: use clsx for conditional styling * fix: fix icons

feat: centralize all constants in constants.ts

2b3eae9

refactor: convert constants to TypeScript enums

0fd6cdf

refactor: split TabType into StreamTab/SourceTab, rename StatusValue-…

142f19f

…>SourceStatus, centralize connector labels in constants

ritoban23 force-pushed the feat/centralize-constants branch from cbc6c3a to 142f19f Compare October 29, 2025 13:36

style: fix linting errors and formatting issues

c1c4a7d

shubham19may force-pushed the staging branch from 0c10a25 to 8335e7e Compare November 11, 2025 12:21

Conversation

ritoban23 commented Oct 15, 2025

Description

Key Changes:

Type of change

How Has This Been Tested?

Test Configuration:

Screenshots or Recordings

Related PR's (If Any):

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ritoban23 commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

deepanshupal09-datazip commented Oct 17, 2025

Uh oh!

deepanshupal09-datazip Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

deepanshupal09-datazip Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

deepanshupal09-datazip Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

deepanshupal09-datazip Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

deepanshupal09-datazip Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

deepanshupal09-datazip Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ritoban23 commented Oct 29, 2025

Uh oh!

deepanshupal09-datazip commented Oct 29, 2025

Uh oh!

deepanshupal09-datazip commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ritoban23 commented Oct 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ritoban23 commented Oct 15, 2025 •

edited

Loading

deepanshupal09-datazip Oct 21, 2025 •

edited

Loading

deepanshupal09-datazip Oct 21, 2025 •

edited

Loading

deepanshupal09-datazip Oct 21, 2025 •

edited

Loading

deepanshupal09-datazip Oct 21, 2025 •

edited

Loading

deepanshupal09-datazip commented Oct 29, 2025 •

edited

Loading