Skip to content

chore: improve docker-compose database env for external database support#278

Open
vishalm0509 wants to merge 9 commits intostagingfrom
chore/external_database_env
Open

chore: improve docker-compose database env for external database support#278
vishalm0509 wants to merge 9 commits intostagingfrom
chore/external_database_env

Conversation

@vishalm0509
Copy link
Copy Markdown
Collaborator

Description

Refactored docker-compose.yml DB envs to use shared x-db-envs anchors and correctly point olake-ui and temporal-worker at the intended Postgres host, port, user, DB name, and SSL mode.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Scenario A
    Tested by using an external database for OLake and temporal
  • Scenario B

Screenshots or Recordings

Related PR's (If Any):

Comment thread docker-compose.yml Outdated
Comment thread docker-compose.yml Outdated
Comment thread docker-compose.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants