feat: Add Configurable SSH Host Key Verification Strategy#652
Open
manish-singh-bisht wants to merge 27 commits intodatazip-inc:stagingfrom
Open
feat: Add Configurable SSH Host Key Verification Strategy#652manish-singh-bisht wants to merge 27 commits intodatazip-inc:stagingfrom
manish-singh-bisht wants to merge 27 commits intodatazip-inc:stagingfrom
Conversation
Contributor
Author
|
@vaibhav-datazip ready for review |
Contributor
Author
|
@vaibhav-datazip mondodb and oracle drivers dont support ssh yet, that is in the other pr #639 |
Collaborator
ohh, really sorry I will comment this there. |
Contributor
Author
|
Hey @nayanj98 ,can you please assign someone to review this pr as well, Would love to continue contributing to olake |
Collaborator
|
Hey @manish-singh-bisht I have assigned @vishalm0509 to review this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #510
extends support for strict host key verification during SSH
Type of change
How Has This Been Tested?
this has been tested by having a docker setup where one container was the db with no ports exported to keep it private, where as the other was a bastion node(ubuntu) in the same network as the db.
Screenshots or Recordings
failed ssh strict verification cases.webm
passing strict verification.webm
Documentation
Related PR's (If Any):