Skip to content

feat: Add Configurable SSH Host Key Verification Strategy#652

Open
manish-singh-bisht wants to merge 27 commits intodatazip-inc:stagingfrom
manish-singh-bisht:ssh_verification_strategy
Open

feat: Add Configurable SSH Host Key Verification Strategy#652
manish-singh-bisht wants to merge 27 commits intodatazip-inc:stagingfrom
manish-singh-bisht:ssh_verification_strategy

Conversation

@manish-singh-bisht
Copy link
Copy Markdown
Contributor

@manish-singh-bisht manish-singh-bisht commented Nov 24, 2025

Description

Fixes #510
extends support for strict host key verification during SSH

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

this has been tested by having a docker setup where one container was the db with no ports exported to keep it private, where as the other was a bastion node(ubuntu) in the same network as the db.

  1. when no host verification mode was providied in config- defaults to insecure
  2. when strict was provided and no path to known_hosts file was provided- throws error
  3. connects via ssh when strict mode and ssh known_hosts file path was provided

Screenshots or Recordings

failed ssh strict verification cases.webm
passing strict verification.webm

Documentation

  • Documentation Link: [link to README, olake.io/docs, or olake-docs]
  • N/A (bug fix, refactor, or test changes only)

Related PR's (If Any):

@manish-singh-bisht manish-singh-bisht changed the title feat: Add Configurable SSH Host Key Verification Strategy WIP feat: Add Configurable SSH Host Key Verification Strategy Nov 24, 2025
@manish-singh-bisht manish-singh-bisht changed the title WIP feat: Add Configurable SSH Host Key Verification Strategy feat: Add Configurable SSH Host Key Verification Strategy Nov 24, 2025
@manish-singh-bisht manish-singh-bisht marked this pull request as ready for review November 24, 2025 09:56
@manish-singh-bisht
Copy link
Copy Markdown
Contributor Author

@vaibhav-datazip ready for review

@manish-singh-bisht
Copy link
Copy Markdown
Contributor Author

@vaibhav-datazip mondodb and oracle drivers dont support ssh yet, that is in the other pr #639

@vaibhav-datazip
Copy link
Copy Markdown
Collaborator

@vaibhav-datazip mondodb and oracle drivers dont support ssh yet, that is in the other pr #639

ohh, really sorry I will comment this there.

@manish-singh-bisht
Copy link
Copy Markdown
Contributor Author

Hey @nayanj98 ,can you please assign someone to review this pr as well,

Would love to continue contributing to olake

@nayanj98
Copy link
Copy Markdown
Collaborator

Hey @manish-singh-bisht I have assigned @vishalm0509 to review this PR.

@nayanj98 nayanj98 requested a review from vishalm0509 December 11, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants