feat(viz): polish choropleth gallery — contrast markers, richer datasets, full-width MapLibre#4087
Merged
Conversation
Address gallery-quality feedback on the choropleth examples: - viz smart's geo (projection) point markers now use a fixed crimson fill with a thin white outline instead of the palette accent. The palette's first color is a blue that disappears against the geo subplot's light-blue ocean (coastal/island points on a world overview); crimson reads on land, water, and in dark themes. - world_cities.csv rebalanced to span all seven continents (33 cities incl. two Antarctic stations), so the smart dashboard's continent breakdown follows the seven-continent convention. - us_cities.csv grown from 20 to 54 cities across ~35 states, so the per-US-state choropleth is densely filled instead of sparse. - The standalone choropleth --map (MapLibre) gallery figure is now rendered full-width: a tile map's zoom is fixed (no geo fitbounds equivalent on the map subplot), so a narrow grid cell cropped it; full-width matches the computed framing width. - Regenerated the gallery; refreshed the LLM world-choropleth iframe. - Drive-by: silence a clippy slice-indexing lint in dashed_box_latlon. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…pleth The smart per-country choropleth is reverse-geocoded from lat/lon, and the geocode engine's reverse() has no distance cutoff, so the two Antarctic stations in world_cities.csv snap to the nearest administering territory (McMurdo -> NZ's Ross Dependency, Rothera -> the Argentine sector) rather than an "Antarctica" fill. No coordinate yields a clean omission. Document this in the gallery figure caption and README, and clarify that the seven-continent grouping comes from the dataset's own continent column (unaffected). Addresses roborev #3238. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
Re-pin the dathere/plotly fork to f4f9f3a4, which adds LayoutGeo `resolution` (GeoResolution: 50 -> 1:50,000,000 base layers). Apply 50m resolution to all geo (projection) subplots — standalone `viz geo`/`viz choropleth` and the smart geo point + choropleth panels — for noticeably crisper coastlines and borders (finer Mediterranean, Caribbean, Indonesian archipelago, Great Lakes, small islands). Tile-map (`--map`) panels are unaffected (no geo subplot). Add a resolution assertion to viz_geo_basic; regenerate the gallery and the LLM world-choropleth iframe. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #4086 (merged) addressing gallery-quality feedback on the new
vizchoropleth examples.Changes
viz smart'sgeo(projection) point markers now use a fixed crimson fill + white outline instead of the palette accent. The palette's first color is a blue that disappears against the geo subplot's light-blue ocean (coastal/island points on a world overview); crimson reads on land, water, and in dark themes.world_cities.csvrebalanced to all seven continents — 33 cities incl. two Antarctic stations, so the smart dashboard's continent breakdown follows the seven-continent convention.us_cities.csvgrown 20 → 54 cities across ~35 states — the per-US-state choropleth is now densely filled (36 states) instead of sparse.--map(MapLibre) choropleth rendered full-width — a tile map's zoom is fixed and themapsubplot has nofitbounds(that's ageo-only attribute), so a narrow grid cell cropped it; full-width matches the computed framing width.reverse()has no distance cutoff, so the two Antarctic stations snap to their nearest administering territory (McMurdo → NZ's Ross Dependency, Rothera → the Argentine sector) rather than an "Antarctica" fill. Noted in the figure caption + README; the seven-continent grouping comes from the dataset's owncontinentcolumn (unaffected).f4f9f3a4(addsLayoutGeo::resolution) and applied 1:50,000,000 (GeoResolution::OneOverFiftyMillion) to all geo subplots for crisper coastlines/borders; tile-map--mappanels unaffected.dashed_box_latlon.gallery.htmland the LLM world-choropleth iframe.Verification
--mapfigure framed with city context instead of cropped.cargo clippyclean,cargo +nightly fmtapplied.Notes
qsv viz smart seismic_events.csv --smarteryields 0 choropleth traces (all-Japan resolves to a single country, correctly suppressed). No change needed.🤖 Generated with Claude Code