Skip to content

fix: wire BUILD_IROH_SERVICES_API_KEY into bundle and release workflows #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zachsmith1 wants to merge 2 commits into
base: main
Choose a base branch
from
+25 −19
Open

fix: wire BUILD_IROH_SERVICES_API_KEY into bundle and release workflows #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86dc324
fix: wire BUILD_IROH_SERVICES_API_KEY into bundle and release workflows
zachsmith1 Apr 28, 2026
b5e97b9
fix: pin dioxus-primitives to a known-good rev
zachsmith1 Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/bundle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:

env:
BUILD_N0DES_API_SECRET: ${{ secrets.N0DES_API_SECRET }}
BUILD_IROH_SERVICES_API_KEY: ${{ secrets.BUILD_IROH_SERVICES_API_KEY }}
Copy link
Copy Markdown
Contributor

@scotwells scotwells Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this API key have access to? Just publishing telemetry?

Copy link
Copy Markdown
Contributor Author

@zachsmith1 zachsmith1 Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Frando do you have a good answer here? from what i can tell there is no fine grained access we can associate with these tokens

Copy link
Copy Markdown
Contributor

@drewr drewr May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Frando Any thoughts?

BUILD_DATUM_CONNECT_RELAY_URLS: ${{ vars.BUILD_DATUM_CONNECT_RELAY_URLS }}
BUILD_DATUM_CONNECT_CREATE_TRAFFIC_PROTECTION_POLICIES: ${{ vars.BUILD_DATUM_CONNECT_CREATE_TRAFFIC_PROTECTION_POLICIES }}
DATUM_API_ENV: production
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/manual-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ jobs:

env:
BUILD_N0DES_API_SECRET: ${{ secrets.N0DES_API_SECRET }}
BUILD_IROH_SERVICES_API_KEY: ${{ secrets.BUILD_IROH_SERVICES_API_KEY }}
BUILD_DATUM_CONNECT_RELAY_URLS: ${{ vars.BUILD_DATUM_CONNECT_RELAY_URLS }}
BUILD_DATUM_CONNECT_CREATE_TRAFFIC_PROTECTION_POLICIES: ${{ vars.BUILD_DATUM_CONNECT_CREATE_TRAFFIC_PROTECTION_POLICIES }}
DATUM_API_ENV: production
Expand Down
36 changes: 18 additions & 18 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion ui/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,11 @@ data-encoding.workspace = true
uuid.workspace = true
n0-error.workspace = true
rustls.workspace = true
dioxus-primitives = { git = "https://github.com/DioxusLabs/components", version = "0.0.1", default-features = false }
# Pinned to a known-good rev: the upstream repo is a moving 0.0.1 git dep
# with no published versioning, and bundle CI runs `cargo generate-lockfile`,
# so without a rev pin every CI run picks up upstream HEAD and breaks
# whenever the Select/Props API drifts. Bump deliberately, never via auto-resolve.
dioxus-primitives = { git = "https://github.com/DioxusLabs/components", rev = "ffbc750181ea2195e20736ae3ad0c24ad9684c41", version = "0.0.1", default-features = false }
sentry.workspace = true

[features]
Expand Down
Loading