Skip to content

fix(dns_dev): emit one addr= TXT entry per address #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachsmith1 merged 1 commit into from
May 1, 2026
Merged

fix(dns_dev): emit one addr= TXT entry per address #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions cli/src/dns_dev.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,12 +161,18 @@ fn build_catalog(config_path: &PathBuf, fallback_origin: &str) -> n0_error::Resu
let z32_id = z32::encode(endpoint_id.as_bytes());
let name = Name::from_str(&format!("_iroh.{z32_id}.{origin}.")).anyerr()?;

// iroh's parser (iroh-relay/src/endpoint_info.rs) runs
// SocketAddr::from_str on each IrohAttr::Addr value as-is and
// silently drops failures, and its serializer emits one
// (Addr, addr.to_string()) attribute per IP. So the canonical
// wire form is one "addr=<single-sockaddr>" TXT entry per
// address, not one "addr=A B C" line.
let mut txt_entries = Vec::new();
if let Some(relay) = record.relay {
txt_entries.push(format!("relay={relay}"));
}
if !record.addrs.is_empty() {
txt_entries.push(format!("addr={}", record.addrs.join(" ")));
for addr in &record.addrs {
txt_entries.push(format!("addr={addr}"));
}
if txt_entries.is_empty() {
continue;
Expand Down
Loading