fix: remove ActivityPolicies for uninstalled route CRDs#148
Merged
Conversation
Remove ActivityPolicy resources for TCPRoute, TLSRoute, and UDPRoute from the milo activity policies. These CRDs are not installed on the project control plane, causing the activity controller to report InProgress status indefinitely. The missing CRDs prevent the network-services-operator core control plane resources kustomization from completing its health checks, blocking all downstream reconciliation.
mattdjenkinson
approved these changes
May 5, 2026
JoseSzycho
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ActivityPolicyresources forTCPRoute,TLSRoute, andUDPRoutefromconfig/milo/activity/policies/gateway.networking.k8s.io) have never been installed on the project control plane, so these policies should never have been addedActivityPolicy targets non-existent resourcefor all three, leaving them stuck inInProgressindefinitelyImpact
The stuck
InProgressstatus causes thenetwork-services-operator-core-control-plane-resourcesFlux kustomization health check to time out on every reconciliation, which has been blocking the kustomization from completing since thefeat-iroh-dns-controllerimage was deployed to staging.