fix: enabling WAF no longer breaks OIDC authentication on gateways#150
Open
fix: enabling WAF no longer breaks OIDC authentication on gateways#150
Conversation
EnvoyPatchPolicy patches for the Coraza WAF filter were using op:add on /typed_per_filter_config, which replaces the entire map and wipes out per-route filter enablement entries written by other filters (e.g., the oauth2 entry that enables OIDC on a route). Now patches target /typed_per_filter_config/<filterName> directly, and the coraza config value no longer wraps itself in the filter name key. Fixes #149 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
kevwilliams
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changing
Fixes a bug where enabling WAF (Web Application Firewall) protection on a gateway would silently break OIDC authentication for that gateway. Users with both WAF and OIDC configured would find their login flow stopped working with no obvious error.
Why it was broken
When the WAF policy was applied, it was accidentally overwriting the configuration that tells the gateway to enforce OIDC authentication on incoming requests — effectively disabling OIDC without any warning.
What this fixes
WAF configuration is now applied more precisely, so it no longer interferes with OIDC or any other security policies on the same gateway.
Fixes #149
Test plan
🤖 Generated with Claude Code