Skip to content

fix: enabling WAF no longer breaks OIDC authentication on gateways#150

Open
scotwells wants to merge 1 commit intomainfrom
fix/tpp-typed-per-filter-config-overwrite
Open

fix: enabling WAF no longer breaks OIDC authentication on gateways#150
scotwells wants to merge 1 commit intomainfrom
fix/tpp-typed-per-filter-config-overwrite

Conversation

@scotwells
Copy link
Copy Markdown
Contributor

@scotwells scotwells commented May 5, 2026

What's changing

Fixes a bug where enabling WAF (Web Application Firewall) protection on a gateway would silently break OIDC authentication for that gateway. Users with both WAF and OIDC configured would find their login flow stopped working with no obvious error.

Why it was broken

When the WAF policy was applied, it was accidentally overwriting the configuration that tells the gateway to enforce OIDC authentication on incoming requests — effectively disabling OIDC without any warning.

What this fixes

WAF configuration is now applied more precisely, so it no longer interferes with OIDC or any other security policies on the same gateway.

Fixes #149

Test plan

  • Gateway with both WAF and OIDC configured — confirm OIDC login flow works end to end
  • Gateway with WAF only — confirm WAF still works as expected
  • Unit tests updated and passing

🤖 Generated with Claude Code

EnvoyPatchPolicy patches for the Coraza WAF filter were using
op:add on /typed_per_filter_config, which replaces the entire map
and wipes out per-route filter enablement entries written by other
filters (e.g., the oauth2 entry that enables OIDC on a route). Now
patches target /typed_per_filter_config/<filterName> directly, and
the coraza config value no longer wraps itself in the filter name key.

Fixes #149

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@scotwells scotwells changed the title fix: target specific key in typed_per_filter_config for coraza WAF patches fix: enabling WAF no longer breaks OIDC authentication on gateways May 5, 2026
@scotwells scotwells requested review from a team and kevwilliams May 5, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OIDC authentication silently stops working when WAF is enabled on the same gateway

2 participants