Open
Conversation
scotwells
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades both publish workflows to
@v1.14.0:publish-docker.yaml: produces container images taggedv0.0.0-main-YYYYMMDD-HHmmssfor branch builds (unchanged from v1.13.1)publish-kustomize-bundle.yaml: now embeds the container image tag directly intoconfig/manager/kustomization.yamlbefore publishing the OCI bundle, via the newimage-nameandimage-overlaysinputsWhy
The infra repo has migrated NSO to semver-based
OCIRepositorytracking (noImagePolicyorImageUpdateAutomation). Staging tracksv0.0.0-main-*bundles; production tracks>= 0.xreleases. Since Flux applies the bundle directly, the bundle must contain the correct container image tag —latestis not acceptable.Prerequisite for infra
After this PR merges, CI will publish
v0.0.0-main-*kustomize bundles with the correct image embedded. Staging will begin deploying automatically. A new release tag must then be cut so production has a>= 0.xbundle to track.Test plan
v0.0.0-main-*v0.0.0-main-*withnewTagset to the same version (notlatest)