Use skin hashes instead of player profile and write to compatible custom-skulls.yml#1
Open
Kas-tle wants to merge 2 commits intodavchoo:mainfrom
Open
Use skin hashes instead of player profile and write to compatible custom-skulls.yml#1Kas-tle wants to merge 2 commits intodavchoo:mainfrom
Kas-tle wants to merge 2 commits intodavchoo:mainfrom
Conversation
Signed-off-by: Joshua Castle <26531652+Kas-tle@users.noreply.github.com>
Signed-off-by: Joshua Castle <26531652+Kas-tle@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently this tool uses a set full base64 encoded player profiles. However, this can still lead to duplicate outputs since the base64 can vary due to white space in the encoded JSON. This PR instead uses the actual set of skin hashes to ensure there are no duplicate outputs.
It also writes to a properly formatted custom-skulls.yml instead of writing to standard output.