Fix: restore the Review file tree - #19
Open
xIGBClutchIx wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This restores the Review side panel's
All filestree in Pocodex so the current Codex desktop bundle can list workspace files and open them from the tree again.What changed
vscode://codex/workspace-directory-entrieshandling in the app-server bridge for the Review file treedirectoryPathrequests against the selected workspace root, reject escapes outside that root, and return workspace-relative entry paths that match the current bundle contractvscode://codex/read-file-metadatasupport with thepath,isFile, andsizeBytesfields the Review file tab expects before loading file contentsRoot cause
vscode://codex/workspace-directory-entries, so the current Codex bundle could not populate theAll filestree in the Review side panelvscode://codex/read-file-metadata, so the bundle stopped before callingread-fileImpact
Review->All filesshows the workspace file tree again in PocodexUnable to load fileValidation
pnpm run check:commitpnpm exec vitest run ./test/app-server-bridge-host-data.test.ts ./test/app-server-bridge-workspace.test.tspnpm exec tsx src/cli.ts --dev --listen 127.0.0.1:8798http://127.0.0.1:8798/thatReview->All filesrenders the repo tree and openingREADME.mdno longer showsUnable to load file