fix test failures with PERL_UNICODE#19
Merged
david-dick merged 1 commit intodavid-dick:mainfrom Oct 19, 2025
Merged
Conversation
Mark STDOUT as binary before printing random bytes to it. Otherwise it will use the system default encoding, which may be UTF-8 if PERL_UNICODE=S or similar is set in the environment.
Fixes this error:
t/getrandom.t .......... 1/?
# Failed test 'getrandom hit with INT signal after 13 bytes recovers to produce correct length of 27 bytes:32'
# at t/getrandom.t line 61.
# EAGAIN looks like 'Failed to getrandom:Resource temporarily unavailable at -e line 1.'
# Looks like you failed 1 test of 6.
Signed-off-by: Lukas Mai <lukasmai.403@gmail.com>
Owner
|
Thanks for the patch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark STDOUT as binary before printing random bytes to it. Otherwise it will use the system default encoding, which may be UTF-8 if PERL_UNICODE=S or similar is set in the environment.
Fixes this error: