Open
Conversation
…vs. pointer explanation
Enhancement/rename
feat: add test_equal target and corresponding test_equal.c file
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames the library from "cBytes" to "bytekit" throughout the codebase. The changes update all references to use the new naming convention and improve consistency in the API design.
- Updates all
#include <cbytes.h>statements to#include <bytekit.h> - Renames header guard and function signatures to use consistent byte_t types
- Adds a new test target for the equal function with conditional compilation
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_equal.c | Updates include statement and adds conditional main function for standalone testing |
| tests/test_copy.c | Updates include statement to use new library name |
| tests/main.c | Updates include statement to use new library name |
| tests/length_test.c | Updates include statement to use new library name |
| tests/index_of_test.c | Updates include statement to use new library name |
| tests/copy_test.c | Updates include statement to use new library name |
| src/bytekit.h | Renames header guard, removes ubyte_t typedef, and standardizes type usage |
| src/bytekit.c | Updates include statement and function signature |
| README.md | Updates library name and improves documentation formatting |
| Makefile | Updates library name references and adds new test target |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+9
to
+10
| typedef byte_t *bytes_t; | ||
| typedef const byte_t *cbytes_t; |
There was a problem hiding this comment.
The typedef byte_t *bytes_t creates a redundant type alias. Since byte_t is already defined as char, this is equivalent to char *bytes_t, which could be confusing. Consider using char * directly or renaming to be more descriptive like byte_array_t.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.