Skip to content

fix(doc): prevent docmap crash #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidgranstrom merged 1 commit into from
Jun 15, 2026
Merged

fix(doc): prevent docmap crash #269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions scide_scnvim/Classes/SCNvimDoc/SCNvimDoc.sc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,6 @@ SCNvimDocEntry : SCDocEntry {
var delimiter = if(lastItem.notNil and:{lastItem}, "", ",");
var inheritance = [];
var numItems;
var keys;

stream << "\"" << path.escapeChar(34.asAscii) << "\": {\n";

Expand All @@ -263,24 +262,25 @@ SCNvimDocEntry : SCDocEntry {
};

if (klass.notNil) {
keys = #[ "superclasses", "subclasses", "implementor" ];
// keep each key paired with its value so a missing entry can't
// shift the labels, and always pass an array to prJSONList
klass.superclasses !? {
inheritance = inheritance.add(klass.superclasses.collect {|c|
inheritance = inheritance.add(["superclasses", klass.superclasses.collect {|c|
c.name.asString
});
}]);
};
klass.subclasses !? {
inheritance = inheritance.add(klass.subclasses.collect {|c|
inheritance = inheritance.add(["subclasses", klass.subclasses.collect {|c|
c.name.asString
});
}]);
};
implKlass !? {
inheritance = inheritance.add(implKlass.name.asString);
inheritance = inheritance.add(["implementor", [implKlass.name.asString]]);
};

numItems = inheritance.size - 1;
inheritance.do {|item, i|
this.prJSONList(stream, keys[i], item, i >= numItems);
inheritance.do {|pair, i|
this.prJSONList(stream, pair[0], pair[1], i >= numItems);
};
};

Expand Down
Loading