Skip to content

Handle help look up on a non-existent class without crashing #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidgranstrom merged 2 commits into from
Jun 16, 2026
Merged

Handle help look up on a non-existent class without crashing #270

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5df4a64
fix(help): pretty guard against nil input_path
salkin-mada Jun 12, 2026
e2dcd63
fix(help): styling unification
salkin-mada Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lua/scnvim/help.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ end
local function render_help_file(subject, on_done)
local cmd = string.format('SCNvim.getHelpUri("%s")', subject)
sclang.eval(cmd, function(input_path)
if not input_path then
utils.print(string.format('The class %s does not exist', subject), 'WarningMsg')
return
end
local basename = input_path:gsub('%.html%.scnvim', '')
local output_path = basename .. '.txt'
local args = get_render_args(input_path, output_path)
Expand Down Expand Up @@ -130,7 +134,7 @@ end
---@param results Table with results
M.on_select = action.new(function(err, results)
if err then
print(err)
utils.print(err, 'WarningMsg')
return
end
local id = api.nvim_create_augroup('scnvim_qf_conceal', { clear = true })
Expand Down
Loading