Revert using highest possible pickle protocol#1164
Closed
micbou wants to merge 2 commits intodavidhalter:masterfrom
Closed
Revert using highest possible pickle protocol#1164micbou wants to merge 2 commits intodavidhalter:masterfrom
micbou wants to merge 2 commits intodavidhalter:masterfrom
Conversation
Owner
Codecov Report
@@ Coverage Diff @@
## master #1164 +/- ##
==========================================
+ Coverage 92.6% 92.61% +0.01%
==========================================
Files 57 57
Lines 6884 6882 -2
==========================================
- Hits 6375 6374 -1
+ Misses 509 508 -1
Continue to review full report at Codecov.
|
Contributor
|
I would say to keep it given that my plan work (#1108 (comment)). |
Owner
|
I'll just leave this one open, let's see what's going to happen. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion in PR #1108. Add a note that the version of the pickle protocol should be increased to 4 when Python 2.7 and 3.3 are dropped.
This change is