Skip to content

Add library search and metadata filtering - #13

Draft
davidhoang wants to merge 2 commits into
mainfrom
cursor/library-search-filter
Draft

Add library search and metadata filtering#13
davidhoang wants to merge 2 commits into
mainfrom
cursor/library-search-filter

Conversation

@davidhoang

Copy link
Copy Markdown
Owner

Summary

  • Add toolbar search that matches filenames, comments, where-from text, tags, and labels
  • Add a filter menu for file type and locally stored tags, with a clear-filters action
  • Show a dedicated "No matches" empty state when filters exclude all images
  • Improve offline/iCloud empty states with Try Again and iCloud-specific copy
  • Add unit tests for LibraryFiltering and UI tests for search/filter controls

This branch also includes the navigation polish from #12 (native sidebar toggle, NavigationStack detail push, inspector persistence). Merge #12 first if you prefer smaller review chunks, or land both together.

Test plan

  • Search by filename, comment, tag, and label in a populated library
  • Filter by file type and tag via the toolbar filter menu
  • Clear filters and confirm the full library returns
  • Confirm "No matches" appears when filters exclude everything
  • Try Again on an offline external drive folder
  • Run UI tests (testPrimaryNavigationControls, testInspectorCanBeToggled)
  • Run unit tests (testLibraryFilteringMatchesNamesTypesAndMetadata)

Made with Cursor

davidhoang and others added 2 commits July 28, 2026 12:06
Remove programmatic sidebar auto-collapse, add a sidebar toggle, push detail via NavigationStack, persist inspector visibility, and drop custom inspector chrome.

Co-authored-by: Cursor <cursoragent@cursor.com>
Toolbar search matches filenames and local metadata, with file type and tag filters, filtered empty states, and UI test coverage for the new controls.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant