Skip to content

Fix file/dir pickers, non-recursive filename scan, build hash in bundle names#17

Open
davidstephengrant wants to merge 3 commits into
masterfrom
dsg-file-picker-fix
Open

Fix file/dir pickers, non-recursive filename scan, build hash in bundle names#17
davidstephengrant wants to merge 3 commits into
masterfrom
dsg-file-picker-fix

Conversation

@davidstephengrant

Copy link
Copy Markdown
Owner

Summary

  • Stale path reset in file/dir pickers: When a stored path has become invalid, clicking to open a file or directory picker now resets that field immediately and falls back to the user's home directory, rather than letting the OS dialog open at an unreachable location. Applies to both drop-zone executable pickers and all three directory pickers (workdir, vtests, testfiles).
  • Non-recursive testfile name scanning: scan_testfile_names previously walked subdirectories recursively, but the vtests scripts only process files directly in the selected directory. Simplified to a flat read_dir over the top level, removing the recursive collect_files helper and the by_parent HashMap.
  • Build hash in bundle file names: Added a build npm script that runs tauri build then renames bundle outputs to insert the git hash (and -dirty flag if applicable) between the version and arch fields — e.g. vtests-gui_0.1.0_5c468e9_amd64.AppImage. Uses the same hash/dirty logic as build.rs.

Test plan

  • Set a path in a drop zone, delete the file, click the drop zone — confirm the field clears and the picker opens in the home directory
  • Set a directory path (workdir/vtests/testfiles), delete the directory, click the button — confirm the field clears and the picker opens in the home directory
  • Place test files in a directory with subdirectories containing invalid names — confirm Validate filenames only reports files in the top level, not in subdirectories
  • Run npm run build — confirm the AppImage is renamed to include the current git hash

🤖 Generated with Claude Code

davidstephengrant and others added 3 commits June 11, 2026 21:33
When a stored path has become invalid, pickers now reset it immediately
on click and fall back to the user's home directory instead of letting
the OS dialog open at an unreachable location.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Scripts only process files directly in the selected directory, so the
recursive collect_files walker was unnecessary. Replaced with a flat
read_dir over the top level only.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds a `build` npm script that runs `tauri build` then renames all
bundle outputs to insert the git hash (e.g. `5c468e9` or `5c468e9-dirty`)
between the version and arch fields:
  vtests-gui_0.1.0_amd64.AppImage → vtests-gui_0.1.0_5c468e9_amd64.AppImage

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant