Update CMakeLists.txt#3109
Conversation
davisking
left a comment
davisking
left a comment
There was a problem hiding this comment.
Thanks for the PR. Please make only the minimal changes needed though.
| if (WIN32 AND NOT "${CMAKE_GENERATOR}" MATCHES "Visual Studio") | ||
| message(FATAL_ERROR "\n" | ||
| "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\n" | ||
| "You must use Visual Studio to build a python extension on windows. If you " | ||
| "are getting this error it means you have not installed Visual C++. Note that " | ||
| "there are many flavors of Visual Studio, like Visual Studio for C\# development. " | ||
| "You need to install Visual Studio for C++. \n" | ||
| "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\n") | ||
| endif() |
There was a problem hiding this comment.
This is very much needed for windows users.
| # When invoked from setup.py CMAKE_LIBRARY_OUTPUT_DIRECTORY will be set. But when you are just building via say | ||
| # `cd dlib/tools/python; mkdir build; cd build; cmake ..` it won't be set. It only matters for building the actual | ||
| # distribution. So skip this for people building directly with cmake (which they might do when testing stuff). | ||
| # Copy __init__.py for Python package |
|
@davisking This PR is not the way we build different libs for Android. We actually use See https://python-for-android.readthedocs.io/en/latest/recipes.html#methods-and-tools-to-help-with-compilation for more info. Below is just a copy if this |
|
Warning: this issue has been inactive for 35 days and will be automatically closed on 2025-10-07 if there is no further activity. If you are waiting for a response but haven't received one it's possible your question is somehow inappropriate. E.g. it is off topic, you didn't follow the issue submission instructions, or your question is easily answerable by reading the FAQ, dlib's official compilation instructions, dlib's API documentation, or a Google search. |
|
Warning: this issue has been inactive for 43 days and will be automatically closed on 2025-10-07 if there is no further activity. If you are waiting for a response but haven't received one it's possible your question is somehow inappropriate. E.g. it is off topic, you didn't follow the issue submission instructions, or your question is easily answerable by reading the FAQ, dlib's official compilation instructions, dlib's API documentation, or a Google search. |
|
Notice: this issue has been closed because it has been inactive for 45 days. You may reopen this issue if it has been closed in error. |
4 participants
#3106