Improve the somewhat flaky test_loss_multibinary_log by avoiding samples very close to class boundaries#3112
Merged
davisking merged 1 commit intoSep 28, 2025
Conversation
…mples very close to class boundaries
Owner
|
Thanks for the PR :D |
reunanen
deleted the
improve-somewhat-flaky-test_loss_multibinary_log
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: This test case (
test_loss_multibinary_log) requires non-zero error, which may be difficult to obtain when samples can be arbitrarily close to the class boundaries.Solution: If a newly generated sample is very close to a class boundary, simply try again.