Skip to content

This version of cmake we were using is now broken in github actions. … #3151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davisking merged 1 commit into from
Jun 28, 2026
+3 −5
Merged

This version of cmake we were using is now broken in github actions. … #3151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/build_cpp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,7 @@ jobs:
- uses: actions/checkout@v2
- name: Configure
run: |
# don't use CMake 3.25.0 https://gitlab.kitware.com/cmake/cmake/-/issues/23975
pip3 install cmake==3.24.0
pip3 install cmake
cmake . -B build
- name: Build just tests
run: cmake --build build --config Release --target dtest --parallel 4
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/build_python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,10 @@ jobs:
- name: Install python deps
run: |
pip install pytest numpy
# don't use CMake 3.25.0 https://gitlab.kitware.com/cmake/cmake/-/issues/23975
pip3 install cmake==3.24.0
pip3 install cmake
- name: Build
run: |
pip3 install cmake==3.24.0
pip3 install cmake
pip3 install .
- name: Test
run: python -m pytest --ignore docs --ignore dlib
Expand Down
Loading