Converted $ macro to use variadic arguments. Added set: and mset: prefixes#2
Open
samgreen wants to merge 5 commits intodbachrach:masterfrom
Open
Converted $ macro to use variadic arguments. Added set: and mset: prefixes#2samgreen wants to merge 5 commits intodbachrach:masterfrom
samgreen wants to merge 5 commits intodbachrach:masterfrom
Conversation
…xes and suffixes with literals using a comma. Otherwise the compiler thinks you’ve supplied too many arguments to the macro.
…o added a test for both prefixes.
Owner
|
Awesome! Will take a deeper look and merge this in soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off, awesome wizardry using the runtime and the new autoboxing to make this library. Really impressive!
I converted the
$macro to use__VA_ARGS__to allow as many arguments as you'd like to the function. This was necessary for the set changes I added, otherwise the comma in the set object list confuses the compiler in to thinking it is a second parameter to the function.Also added tests for these new items, as well as stringized tests to ensure they will be equivalent. We might want to move the code to the base block for cleaning stringized items. Open to feedback on this.