This repository was archived by the owner on Nov 15, 2022. It is now read-only.
Update for Hyper-V#1
Open
jeromemartin wants to merge 4 commits into
Open
Conversation
|
Would be good to squash those 2 commits. @javornikolov one for you to review? |
javornikolov
reviewed
Mar 7, 2019
| spec.homepage = "https://github.com/dbfit/vagrant-newdisk" | ||
| spec.summary = %q{Vagrant plugin to add VirtualBox/Hyper-V disk} | ||
| spec.description = %q{Vagrant plugin to add VirtualBox/Hyper-V disk at creation time} | ||
| spec.homepage = "https://github.com/jeromemartin/vagrant-newdisk" |
Contributor
There was a problem hiding this comment.
Should we change that homepage url considering that we're merging these changes under dbfit/vagrant-newdisk?
Author
There was a problem hiding this comment.
If the PR is accepted, it should not be changed
javornikolov
reviewed
Mar 7, 2019
| # the path on the guest to mount the folder. And the optional third | ||
| # argument is a set of non-required options. | ||
| # config.vm.synced_folder "../data", "/vagrant_data" | ||
| config.vm.synced_folder ".a", "/vagrant_data", disabled: true |
Contributor
There was a problem hiding this comment.
Why do we need that change?
Author
There was a problem hiding this comment.
This change was not necessary: I have just pushed my testing Vagrantfile by mistake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proposed PR makes the plugin working for Hyper-V