test: run BEAM suites in parallel again on Quill 0.5.1 / Nib 0.4.1 - #67
Merged
Conversation
Scriptorium released the two BEAM fixes we were waiting on: - Quill 0.5.1 - correct Unicode output on the BEAM target (Scriptorium #14) - Nib 0.4.1 - render char-level diffs as characters on BEAM (Scriptorium #15) Those were the root cause of the garbled "1" diffs that made the remoting body assertions flake when the BEAM suites ran under Quill's default cross-suite concurrency. With them in, `test/beam/Main.fs` drops the `testSequenced` wrapper and runs the three suites with plain parallel `runTests`, matching the Python and JS runners. Bumped Quill 0.5.0 -> 0.5.1 and Nib 0.4.0 -> 0.4.1 in all three test projects, and updated CLAUDE.md: BEAM now has one residual caveat (`toWireKey`) rather than two. Verified green on all three targets - BEAM 47 passed | 8 skipped over five consecutive runs (the old failure was intermittent), Python 55 passed, JS 53 passed | 2 skipped. Closes #54 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scriptorium released the two BEAM fixes tracked in #54:
Those were the root cause of the garbled
"1"diffs that made the remoting body assertions flake when the BEAM suites ran under Quill's default cross-suite concurrency.Changes
test/beam/Main.fs— drop thetestSequencedwrapper, theopen type Scriptorium.Quill.Testit needed, and the workaround comment; back to plain parallelrunTests [ HandlerTests.tests; RoutingTests.tests; RemotingTests.tests ], matching the Python and JS runners.Scriptorium.Quill0.5.0 → 0.5.1 andScriptorium.Nib0.4.0 → 0.4.1 in all three test projects (test/beam,test/js,test/python).CLAUDE.md— BEAM now has one residual caveat (toWireKey) rather than two; note thetestSequencedworkaround is gone.Verification
All three targets green:
BEAM was run five times specifically because the original failure was intermittent; no flakes.
Closes #54
🤖 Generated with Claude Code