Skip to content

Update all usages of faker's randomDigit to randomNumber#118

Open
smithandre wants to merge 2 commits intodbudwin:masterfrom
smithandre:master
Open

Update all usages of faker's randomDigit to randomNumber#118
smithandre wants to merge 2 commits intodbudwin:masterfrom
smithandre:master

Conversation

@smithandre
Copy link

Updating all usages of faker's randomDigit to randomNumber

Description

Changed all usages of Faker's randomDigit to randomNumber

Motivation and Context

A stab at solving #94

How Has This Been Tested?

I executed PHPuni tests locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking change which is not noticeable to end users)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires an update to the README and I have updated it accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • This is a complete change and doesn't leave the project in a bad state.
  • All new and existing tests passed.

@dbudwin
Copy link
Owner

dbudwin commented Oct 13, 2017

Thanks for looking into this. A few housekeeping items first. Can you please open up a pull request from a branch that isn't master and can you also squash your two commits together to remove your internal merge commit. Also please be sure to check the appropriate boxes with an "X" for "Types of changes" and "Checklist" section in your PR description.

https://github.com/dbudwin/RoboHome-Web/blob/master/CONTRIBUTING.md#making-changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants