Implemented localization in English, Spanish, and Japanese#91
Open
Implemented localization in English, Spanish, and Japanese#91
Conversation
This will aide in localizing pages more easily. https://github.com/mcamara/laravel-localization
Just followed the instructions in the README for the project: https://github.com/mcamara/laravel-localization
The big `laravellocalization.php` file was created by following the README in the project: `php artisan vendor:publish --provider="Mcamara\LaravelLocalization\LaravelLocalizationServiceProvider"` This makes a copy of the config file so it can be versioned.
They weren't being used and were shipped with Laravel by default.
The language can be switched on the login screen in the upper-right hand corner.
There isn't much value to linting the language files, it just through false positives.
dbudwin
force-pushed
the
Localization
branch
from
eecc7c0 to
b4bf424
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support localizing pages in three languages: English, Spanish, and Japanese. These are the languages I have at least some familiarity with. Better translations will be needed.
The language can be switched using the upper right-hand corner of the login page.