fix(workspace): prevent invalid exception when opening prefix in RW m…#587
Merged
Conversation
…ode fails Fixed issue #334 where opening a locked prefix in read-write mode would throw exception and Workspace open silences exception and returns null. Right now null is returned only when PrefixNotFoundException is thrown. Changes: - Added new exception type PrefixNotFoundException for clearer error handling - Modified PrefixCatalog, Workspace, and PyEnumType to throw PrefixNotFoundException instead of InputException when prefix does not exist - Improved error handling in Workspace::open() to properly clean up incomplete files for all exception types while preserving the original exception for non-prefix-not-found cases Fixes #334
wskozlowski
approved these changes
Dec 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(workspace): prevent invalid exception when opening prefix in RW mode fails
Fixed issue #334 where opening a locked prefix in read-write mode would throw exception and Workspace open silences exception and returns null. Right now null is returned only when PrefixNotFoundException is thrown.
Changes:
Fixes #334