issue-694 Added support for del operator in a dbzero.list#696
Closed
sigsegvdev wants to merge 1 commit into
Closed
issue-694 Added support for del operator in a dbzero.list#696sigsegvdev wants to merge 1 commit into
sigsegvdev wants to merge 1 commit into
Conversation
|
Tomasz Wejroch seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
sigsegvdev
commented
Jan 8, 2026
| { | ||
| if (size() == 0) { | ||
| THROWF(db0::InputException) << "Cannot pop from empty container "; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
I removed this check because it's redundant and also cause inconsistent behavior, where we get a different exception depending whether the list is empty or not - this is not how standard python list works
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#694