Add support for MariaDB#31
Open
jsongerber wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows this package to work with MariaDB.
In MariaDB,
--set-gtid-purgedonmysqldumpdoes not exist and throws an error.Here is the changes I made:
REMOTE_DATABASE_TYPEconfig variable, with the default value tomysql, so there is no breaking changeREMOTE_DATABASE_TYPEis set tomysql,--set-gtid-purged=OFFis used, otherwise it is notREMOTE_DATABASE_TYPEis set tomysql,mysqldumpis used, otherwisemariadb-dumpis usedThere's some observation/question where you maybe can help:
REMOTE_DATABASE_MYSQL_HOSTNAMEuse mysql in its name, which could be confusing now that MariaDB is supported, not a big deal and changing it would be a breaking change. A solution could be to have a newREMOTE_DATABASE_HOSTNAME(without mysql) variable, and throw a deprecation notice when the old one is used.REMOTE_DATABASE_TYPEis not strict, onlymysqluses--set-gtid-purged=OFF, any other string is not using it. So usingmariadbwould have the same effect asfoobar.mysqldumpis still available with MariaDB, but deprecated,mariadb-dumpis replacing it.Closes #30