Skip to content

exclude optional dependencies from classLoader #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dcdh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

exclude optional dependencies from classLoader #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion ...lver/src/main/java/io/quarkus/bootstrap/resolver/maven/ApplicationDependencyResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import org.eclipse.aether.artifact.Artifact;
import org.eclipse.aether.artifact.DefaultArtifact;
import org.eclipse.aether.collection.CollectRequest;
import org.eclipse.aether.collection.DependencyCollectionContext;
import org.eclipse.aether.collection.DependencyCollectionException;
import org.eclipse.aether.collection.DependencySelector;
import org.eclipse.aether.graph.DefaultDependencyNode;
Expand All @@ -40,7 +41,9 @@
import org.eclipse.aether.resolution.ArtifactRequest;
import org.eclipse.aether.resolution.ArtifactResolutionException;
import org.eclipse.aether.util.artifact.JavaScopes;
import org.eclipse.aether.util.graph.selector.AndDependencySelector;
import org.eclipse.aether.util.graph.selector.ExclusionDependencySelector;
import org.eclipse.aether.util.graph.selector.ScopeDependencySelector;
import org.jboss.logging.Logger;

import io.quarkus.bootstrap.BootstrapConstants;
Expand Down Expand Up @@ -522,11 +525,31 @@ private DependencyNode resolveRuntimeDeps(CollectRequest request)
}
}

public static final class StrictNoOptionalDependencySelector implements DependencySelector {

@Override
public boolean selectDependency(Dependency dependency) {
return !dependency.isOptional();
}

@Override
public DependencySelector deriveChildSelector(DependencyCollectionContext context) {
return this;
}
}

private DefaultRepositorySystemSession getSessionWithDirectDepsCollector() {
final RepositorySystemSession session = resolver.getSession();
final DefaultRepositorySystemSession mutableSession = new DefaultRepositorySystemSession(session);
// override session defined in
DependencySelector depFilter = new AndDependencySelector(
new ScopeDependencySelector("test", "provided"),
new StrictNoOptionalDependencySelector(),
new ExclusionDependencySelector());
// mutableSession.setDependencySelector(
// new DirectDependencyCollectorFactory(session.getDependencySelector(), dependencyMap));
mutableSession.setDependencySelector(
new DirectDependencyCollectorFactory(session.getDependencySelector(), dependencyMap));
new DirectDependencyCollectorFactory(depFilter, dependencyMap));
return mutableSession;
}

Expand Down
Loading